ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesse Glick <jesse.gl...@sun.com>
Subject Re: Bugzilla Issue 45902 (Up-to-date checks for JARs broken due to comparison of dir timestamps)
Date Thu, 29 Jan 2009 16:59:13 GMT
Stefan Bodewig wrote:
>>> * a single empty directory is added to the sources - I think Ant will
>>>   now no longer create a new archive
> 
>> Is this really a bug?
> 
> Some people say so
> 
> https://issues.apache.org/bugzilla/show_bug.cgi?id=20366

True, although skipping dir timestamps just means that such a source change will not trigger
a rebuild of the JAR during an incremental build. That can be expected to be 
a much rarer situation than doing a full build when the empty source dir already exists.

> Did I sound like "if you think you understand Zip.java better than I
> do"?  If so, please forgive me, this was in no way intended.

I just meant that you likely have a deeper understanding of Zip - and in particular the newer
resource collection framework - than I do. My fix solved the case at hand, 
but there is likely a better fix somehow involving the dir entry creation code.

> in many if not
> most cases you don't really care for the timestamps of the directories
> so even the second task shouldn't recreate the archive.

Perhaps, although as far as I know it is relatively uncommon for a dir timestamp to change
without the timestamp of any of the contained files to change, so if JARs are 
recreated in this situation it would not be a significant annoyance even if you care nothing
for directory entry timestamps.

> And if you
> do, the third and fourth tasks shouldn't do anything.

Right, that is the real bug in my mind.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message