Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 85443 invoked from network); 17 Nov 2008 08:02:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Nov 2008 08:02:15 -0000 Received: (qmail 6017 invoked by uid 500); 17 Nov 2008 08:02:22 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 5972 invoked by uid 500); 17 Nov 2008 08:02:22 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 5961 invoked by uid 99); 17 Nov 2008 08:02:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Nov 2008 00:02:22 -0800 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [88.84.142.181] (HELO samaflost.de) (88.84.142.181) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Nov 2008 08:00:58 +0000 Received: from localhost (unknown [127.0.0.1]) by samaflost.de (Postfix) with ESMTP id 10216E220014 for ; Mon, 17 Nov 2008 08:01:42 +0000 (UTC) Received: from samaflost.de ([127.0.0.1]) by localhost (v30161.1blu.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 03581-06 for ; Mon, 17 Nov 2008 09:01:40 +0100 (CET) Received: by samaflost.de (Postfix, from userid 2525) id 0636EE22000A; Mon, 17 Nov 2008 09:01:39 +0100 (CET) To: dev@ant.apache.org Subject: Re: svn commit: r714053 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/MappedResource.java X-Draft-From: ("nnfolder:mail.jakarta-ant" 90877) References: <20081114160431.88747238889C@eris.apache.org> From: Stefan Bodewig Date: Mon, 17 Nov 2008 09:01:39 +0100 In-Reply-To: ("Nicolas =?iso-8859-1?Q?Lalev=E9e=22's?= message of "Fri\, 14 Nov 2008 20\:01\:52 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Virus-Scanned: amavisd-new at samaflost.de X-Virus-Checked: Checked by ClamAV on apache.org On 2008-11-14, Nicolas Lalev�e wrote: > I am not sure of how are used the "Resource" in the Ant code, but it > makes me think of the Eclipse adapters (probably a design pattern ?): > http://www.jeffreyricker.com/papers/Eclipse-Adapters.pdf Sounds reasonable. > Though it changes the tests of the appendability, the touchability, > etc... of a Resource in the ant code, the "instanceof+cast" would be > replaced by some "getAdapter". This solution is not very self- > contained... Yes. I may stick a single subclass for FileProvider resources and modify all occurances of Appendable and Touchable to use the adapter method. > But I see another solution, quite different. Probably most of the work > should be done in the Resource class: I thought about that, but Resource is already doing way too much IMHO. Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org