ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Louis BOUDART" <jeanlouis.boud...@gmail.com>
Subject Re: EasyAnt <use>/<extends> vs <import>
Date Wed, 12 Nov 2008 21:21:44 GMT
Ooops i forgot "ignoring" prefix should ignore also prefix separator


2008/11/12 Jean-Louis BOUDART <jeanlouis.boudart@gmail.com>

> Maybe this should be done with a additional attribute like :
> - ignorePrefix
> - disablePrefix
>
> something like
> <import file="..." disablePrefix="true"/>
>
> WDYT?
>
>
> 2008/11/12 Jean-Louis BOUDART <jeanlouis.boudart@gmail.com>
>
>> Ooops my bad, i've merged with my previous patch :$
>> This is now fixed in:
>>
>> http://easyant.abrm.info/trac/browser/trunk/src/main/patches/ant-713373-easyant-patch.diff
>>
>> The patch contains only things related to phases concept.
>>
>> In addition to this, i think that we should add a way to disable
>> prefixing, i have a use case in easyant where i don't want to use prefix.
>> In the patch i removed this control:
>>   if (configuredValue != null && configuredValue.length() == 0) {
>>                 configuredValue = null;
>>   }
>>
>> This allow me to have a dirty fix to import a build script without prefix
>> :) by setting as attribute to an empty string (<import file="..." as=""/>).
>>
>>
>>
>>
>> 2008/11/12 Stefan Bodewig <bodewig@apache.org>
>>
>>> On 2008-11-12, Jean-Louis BOUDART <jeanlouis.boudart@gmail.com> wrote:
>>>
>>> > EasyAnt switched to ant-713373
>>>
>>> > Every things seems ok, except prefix separator should be applied on
>>> targets
>>> > (ie. in targetHelper) too.
>>>
>>> >
>>> http://easyant.abrm.info/trac/browser/trunk/src/main/patches/ant-713373-easyant-patch.diff
>>>
>>> Both places where your patch replaces "." with prefixSeparator (line
>>> 861 and line 888 of the original) are correct in svn, you must be
>>> using some inconsistent state since your patch won't apply.
>>>
>>> I'm a bit puzzled since I never committed a version that had
>>> prefixSeparator only in one place but not the other two.
>>>
>>> Stefan
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>>> For additional commands, e-mail: dev-help@ant.apache.org
>>>
>>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message