Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 51035 invoked from network); 8 Sep 2008 12:58:02 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Sep 2008 12:58:02 -0000 Received: (qmail 12261 invoked by uid 500); 8 Sep 2008 12:57:59 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 12222 invoked by uid 500); 8 Sep 2008 12:57:58 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 12211 invoked by uid 99); 8 Sep 2008 12:57:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Sep 2008 05:57:58 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [88.84.142.181] (HELO samaflost.de) (88.84.142.181) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Sep 2008 12:57:01 +0000 Received: from localhost (unknown [127.0.0.1]) by samaflost.de (Postfix) with ESMTP id 2A13DE220014 for ; Mon, 8 Sep 2008 12:57:01 +0000 (UTC) Received: from samaflost.de ([127.0.0.1]) by localhost (v30161.1blu.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 29921-06 for ; Mon, 8 Sep 2008 14:56:57 +0200 (CEST) Received: by samaflost.de (Postfix, from userid 2525) id 65E6BE22000A; Mon, 8 Sep 2008 14:56:57 +0200 (CEST) To: dev@ant.apache.org Subject: Re: DirectoryScanner and Symlinks X-Draft-From: ("nnfolder:mail.jakarta-ant" 89122) References: <255d8d690809040838h63d26ab3y6b262f13a0dd6115@mail.gmail.com> From: Stefan Bodewig Date: Mon, 08 Sep 2008 14:56:57 +0200 In-Reply-To: (Gilles Scokart's message of "Mon\, 8 Sep 2008 12\:31\:41 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: amavisd-new at samaflost.de X-Virus-Checked: Checked by ClamAV on apache.org On Mon, 8 Sep 2008, Gilles Scokart wrote: > I fear that with this aproach, you may have to "rollback" some of > the files already scanned because you will detect a loop after you > have already looped one or more time (including multiple time the > same files). We'd detect the loop as soon as the maximum for recursion is reached, I don't think any rollback will be needed. > This "rollback" will be required if you want to provide a "clean" > fileset when the patterns (and file system) would give infinite > loop. I don't intend to do that at all. You'll get MAX recursions and no more - but no less either if you give us an infinite pattern. > The other aproach might be to fail the build if an infinite loop is > detected. What is wrong with the failing aproach? The original report was about recursing endlessly while scanning something in JAVA_HOME (a fileset to grab all jars from the extension dir would be my guess) without any user intervention - and JAVA_HOME points to a symbolic link that points to a parent on this particular Mac installation (I no longer have a working Mac to check myself). Note this is a fileset created by Ant internally and not defined by the user. Failing the build, while it is what we currently do, will not help people in a situation like this, in particular not if they aren't allowed to change the filesystem layout of the Java installation. Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org