ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles Scokart" <gscok...@gmail.com>
Subject Re: svn commit: r695402 - in /ant/core/trunk/src/main/org/apache/tools/ant: DirectoryScanner.java types/selectors/PathPattern.java types/selectors/SelectorUtils.java
Date Tue, 16 Sep 2008 15:08:08 GMT
2008/9/16 Stefan Bodewig <bodewig@apache.org>:
> On Tue, 16 Sep 2008, Gilles Scokart <gscokart@gmail.com> wrote:
>
>> I'm still thinking that a 'PathPattern' and a 'PathValue' (or
>> whatever name you preffer) are two different things that have
>> enought reality to exists as independent classes.
>
> I tried to come up with a different name for the class and failed to
> find anything meaningful, so yes, there probably is room for two
> separate classes (TokenizedPattern and TokenizedPath?).
>
> I'm willing to explore this - and to explore even more places in
> DirectoryScanner where we tokenize the same strings more than once.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>

There is one very big case : when we recurse, we tokenize again and
again the beguin of the path.  But I don't think you can change that
by keeping the current protected API.

-- 
Gilles Scokart

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message