ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles Scokart" <gscok...@gmail.com>
Subject Re: DirectoryScanner and Symlinks
Date Wed, 10 Sep 2008 19:58:40 GMT
2008/9/10 Stefan Bodewig <bodewig@apache.org>:
> On Mon, 8 Sep 2008, Dominique Devienne <ddevienne@gmail.com> wrote:
>
>> On Mon, Sep 8, 2008 at 5:01 AM, Stefan Bodewig <bodewig@apache.org> wrote:
>> > Does that sound OK?
>>
>> Sounds good to me.
>
> Of course we'd first check when we hit the name for the (MAX + 1)th
> time not for the MAXth time since the former would be allowed.  I
> wonder whether MAX = 1 would be a better default than 5.
>
>> I'd simply add a warning indicating maxSymlinkTraversal was
>> hit. "User" or verbose level is debatable again.
>
> Probably a good idea.
>
>> Similarly, maybe an internal flag in DS should be gettable to
>> possibly have client code remove duplicate entries if it wants to???
>
> Not sure what you mean here.
>

If I take the example,
          I <-----\
         / \      |
        /   \     |
       B     C    |
      /       \   |
     /         \  |
 file.txt      A--/

and I start with /, with the pattern /**/*.txt, even with a
maxLevelsOfSymlinks 1, I will get
/B/file.txt
/C/A/B/file.txt

Clearly, you get twice the same file.  Maybe that's not what the user
want.  But which one should we choose?


-- 
Gilles Scokart

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message