ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Radeski" <a...@radeski.net>
Subject Re: OSGi friendly LatestRevisionStrategy patch
Date Mon, 01 Sep 2008 07:30:08 GMT
On Mon, Sep 1, 2008 at 7:43 AM, Xavier Hanin <xavier.hanin@gmail.com> wrote:

Hi Xavier,

> While I understand the your point of view, the change you request may imply
> breaking versionning strategies for people using for years. Hence I'm not in
> favor of changing this, at least we need to provide an easy to use backward
> compatible version of this strategy.

That's a fair point, I wouldn't want to break backward compatibility.I
should explain that I appended the OSGi-like versions to the unit test
in my previous post, i probably should have created a separate unit
test. So the old test still passes with the new implementation, hence
still backward compatible.

>
> Once you have defined the defaultLatestStrategy, you shouldn't have to
> specify it everywhere. If you have to, it's a bug, please report it with a
> JIRA.

Ok, I'll double check this was an issue.

> As I said, I don't think we can use it like this. But maybe we could find a
> way for the latest revision strategy to behave as you want or as before. It
> could be an attribute, which value could be set either directly, or through
> an Ivy variable. Then switching to OSGi mode would only require setting one
> variable, instead of what you do now.
>
> What do you and others think about that?

I think what you say is pretty fair. Rather than patching the
LatestReviStrategy class, we could provide a separate OSGi-friendly
class.

Alex.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message