ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xavier Hanin" <xavier.ha...@gmail.com>
Subject Re: svn commit: r693493 - /ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorBuilder.java
Date Wed, 10 Sep 2008 06:15:37 GMT
On Wed, Sep 10, 2008 at 6:46 AM, <Jan.Materne@rzf.fin-nrw.de> wrote:

> URL: http://svn.apache.org/viewvc?rev=693493&view=rev
> Log:
> review packaging to ext mapping (related to IVY-899)
>
> Modified:
>
> ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDe
> scriptorBuilder.java
>
> +    private static final Collection/*<String>*/ JAR_PACKAGINGS =
> Arrays.asList(
> +                new String[] {"ejb", "bundle", "maven-plugin"});
>
>
>          if ("pom".equals(packaging)) {
>             // no artifact defined!
>             return;
> -        } else if ("ejb".equals(packaging)) {
> +        } else if (JAR_PACKAGINGS.contains(packaging)) {
>             ext = "jar";
>         } else {
>             ext = packaging;
>         }
>
>
> Not sure what JAR_PACKAGINGS should be. But if it lists all possible
> packagings, shouldnt "pom" be listed there too?

It lists only packagings for which the ext should be jar. pom packaging is
already handled by the if("pom".equals(packaging)) line.

Xavier

>
>
> Jan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>


-- 
Xavier Hanin - Independent Java Consultant
BordeauxJUG co leader - http://www.bordeauxjug.org/
Blogger - http://xhab.blogspot.com/
Apache Ivy Creator - http://ant.apache.org/ivy/

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message