ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nicolas Lalevée <nicolas.lale...@hibnet.org>
Subject Re: AW: AW: svn commit: r697019 - in /ant/ivy/ivyde/trunk: org.apache.ivyde.eclipse/ org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cpcontainer/ test/ivy-base-dir/ test/ivy-base-dir/settings/ test/ivy-base-dir/src/
Date Fri, 19 Sep 2008 12:16:19 GMT
Le vendredi 19 septembre 2008, Jan.Materne@rzf.fin-nrw.de a écrit :
> >> >             if (ivySettingsLastModified == -1) {
> >> >                 Message.info("\n\n");
> >> >             } else {
> >> >                 Message.info("\n\nIVYDE: ivysettings has changed,
> >>
> >> The info message completely in lower case?
> >
> >is there any worry about it ?
>
> Not really. But if you present a log message (like the Exception
> strings)
> I think it would be better to write
> 	Message.info("\n\nIVYDE: Ivy-settings has changed, configuring
> Ivy again\n");
> Or is "ivysettings" a technical term?

well, in Ivy's literature, I used to read about some "ivyconf", so with the 
new terminology, it becames "ivysettings". It looks understandable for me.
But I don't have any objection to change every occurence of it into "Ivy 
settings".

Nicolas

>
> >> Why just the two new lines when -1?
> >
> >The two new lines are I think because we are probably starting
> >a new resolve
> >session, so this need to be somehow visible.
> >And -1 means that the file has not been loaded yet, so there
> >is no reloading
> >to log about.
>
> Ok, thanks
>
>
> Jan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message