ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xavier Hanin" <xavier.ha...@gmail.com>
Subject Re: svn commit: r683187 - /ant/ivy/core/trunk/test/java/org/apache/ivy/ant/IvyTaskTest.java
Date Wed, 06 Aug 2008 15:25:09 GMT
On Wed, Aug 6, 2008 at 2:42 PM, Stefan Bodewig <bodewig@apache.org> wrote:

> On Wed, 6 Aug 2008, Xavier Hanin <xavier.hanin@gmail.com> wrote:
>
> On Wed, Aug 6, 2008 at 11:38 AM, Gilles Scokart <gscokart@gmail.com>
> wrote:
>
> >> Could someone retest that in an other environment (I only have
> >> access to an IBM JVM).
> >
> > I'm not on my dev box now, so I can't confirm it works, but I see no
> > reason why it would fail. That being said, I think it would be
> > cleaner to extract this "trick" in a helper method.
>
> Since the code is used in the ant package, you might as well use
> org.apache.tools.ant.util.FileUtils' getFileURL or toURI methods which
> have the added benefit of working with Java < 1.4 as well.

Thanks for the tip. But the code concerned by this file to URL conversion
spans outside the ant package (this commit is only a small part, see Maarten
recent commit), so we need a solution which doesn't rely on Ant codebase.

Xavier


>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>


-- 
Xavier Hanin - Independent Java Consultant
http://xhab.blogspot.com/
http://ant.apache.org/ivy/
http://www.xoocode.org/

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message