ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: Ivy svn breaks ant-contrib svn
Date Tue, 15 Jul 2008 12:13:10 GMT
On Tue, 15 Jul 2008, Xavier Hanin <xavier.hanin@gmail.com> wrote:

> On Tue, Jul 15, 2008 at 9:23 AM, Stefan Bodewig <bodewig@apache.org> wrote:
> 
> > On Tue, 15 Jul 2008, Xavier Hanin <xavier.hanin@gmail.com> wrote:
> >
> > > On Tue, Jul 15, 2008 at 8:53 AM, Stefan Bodewig <bodewig@apache.org>
> > wrote:
> > >
> > > > Ant-contrib also invokes setId() on the task, which works fine with
> > > > Ivy 2.0.0beta2 but fails with trunk.
> > > >
> > > > Could you please re-add the setid method?
> > >
> > > setId is now setSettingsId on IvyConfigure, which is more in
> > > conformance with Ant, since we are not setting the id of the
> > > task, but of the underneath datatype.
> >
> > OK, what can ant-contrib do if it wants to compile against Ivy
> > 2.0.0beta2 and trunk with the same codebase?
> 
> This is not straightforward, since we broke the API.

Right, that's why Gump finds it 8-)

Maybe you could throw in a deprecated setId() method that delegated to
setSettingsId()?  At least for the next beta so ant-contrib has a
stable base to work from without resorting to reflection.

I looked into the code to see what the id is used for.  It is later
used as the argument for IvyCacheFileset.setSettingsRef - this
wouldn't work with a reference to the task but would require a
reference to the settings, which now would exactly be what
setSettingsId creates, right?

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message