ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xavier Hanin" <xavier.ha...@gmail.com>
Subject Re: svn commit: r679119 - in /ant/ivy/ivyde/trunk/org.apache.ivyde.eclipse: ./ src/java/org/apache/ivyde/eclipse/cpcontainer/ src/java/org/apache/ivyde/eclipse/ui/preferences/
Date Thu, 24 Jul 2008 08:59:12 GMT
On Thu, Jul 24, 2008 at 9:42 AM, Nicolas Lalevée <nicolas.lalevee@hibnet.org>
wrote:

> Le jeudi 24 juillet 2008, Xavier Hanin a écrit :
> > On Wed, Jul 23, 2008 at 6:03 PM, <hibou@apache.org> wrote:
> > > Author: hibou
> > > Date: Wed Jul 23 09:03:45 2008
> > > New Revision: 679119
> > >
> > > URL: http://svn.apache.org/viewvc?rev=679119&view=rev
> > > Log:
> > > IVYDE-105 : Retrieve after resolve feature does not clean target
> > > directory first
> > >  - added a button in the UI to "synchronize" the retrieve
> >
> > [...]
> >
> > > ---
> > >
> ant/ivy/ivyde/trunk/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/ec
> > >lipse/ui/preferences/IvyPreferencePage.java (original)
> > > +++
> > >
> ant/ivy/ivyde/trunk/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/ec
> > >lipse/ui/preferences/IvyPreferencePage.java Wed Jul 23 09:03:45 2008
> > > @@ -56,6 +56,8 @@
> > >
> > >     private StringFieldEditor _pattern;
> > >
> > > +    private BooleanFieldEditor _retreiveSync;
> >
> > There's a typo here, it should be _retrieveSync
>
> arg, this is the second time I did that spell mistake.

There used to be several such same typo, so you're not the only (french) guy
to make this mistake :-)


>
>
> >
> > > +
> > >     public IvyPreferencePage() {
> > >         super(GRID);
> > >
> setPreferenceStore(IvyPlugin.getDefault().getPreferenceStore());
> > > @@ -123,6 +125,7 @@
> > >                 b.addSelectionListener(new SelectionAdapter() {
> > >                     public void widgetSelected(SelectionEvent e) {
> > >                         _pattern.setEnabled(b.getSelection(), parent);
> > > +                        _retreiveSync.setEnabled(b.getSelection(),
> > > parent);
> > >                     }
> > >                 });
> > >             }
> > > @@ -131,8 +134,11 @@
> > >                 fieldParent);
> > >
> > >
> _pattern.setEnabled(getPreferenceStore().getBoolean(PreferenceConstants.D
> > >O_RETRIEVE), fieldParent);
> > > +        _retreiveSync = new
> > > BooleanFieldEditor(PreferenceConstants.RETRIEVE_SYNC,
> > > +                "Delete old retrieved artifacts", fieldParent);
> > >         addField(doR);
> > >         addField(_pattern);
> > > +        addField(_retreiveSync);
> > >
> > >         new Label(fieldParent, SWT.NONE); // space
> > >         explanation = new Label(fieldParent, SWT.NONE);
> > >
> > > Modified:
> > >
> ant/ivy/ivyde/trunk/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/ec
> > >lipse/ui/preferences/PreferenceConstants.java URL:
> > >
> http://svn.apache.org/viewvc/ant/ivy/ivyde/trunk/org.apache.ivyde.eclipse
> >
> >/src/java/org/apache/ivyde/eclipse/ui/preferences/PreferenceConstants.java
> > >?rev=679119&r1=679118&r2=679119&view=diff
> > >
> > >
> =========================================================================
> > >===== ---
> > >
> ant/ivy/ivyde/trunk/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/ec
> > >lipse/ui/preferences/PreferenceConstants.java (original)
> > > +++
> > >
> ant/ivy/ivyde/trunk/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/ec
> > >lipse/ui/preferences/PreferenceConstants.java Wed Jul 23 09:03:45 2008
> > > @@ -48,6 +48,8 @@
> > >
> > >     public static final String RETRIEVE_PATTERN = "retreive.pattern";
> > >
> > > +    public static final String RETRIEVE_SYNC = "retreive.sync";
> > > +
> >
> > Same typo as above for the constant value. But I also realize we have the
> > same typo for the retrieve pattern value. I'd prefer fixing it, but it
> > would be a backward incompatible change with alpha1. But alpha1 is only
> an
> > alpha, so I'd still prefer fixing it, unless you have another opinion.
>
> Actually I think we can fix and keep it backward compatible: write the
> property with the fixed spell, but read both form.
> I will fix it.

Great!

Xavier



>
>
> cheers,
> Nicolas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>


-- 
Xavier Hanin - Independent Java Consultant
http://xhab.blogspot.com/
http://ant.apache.org/ivy/
http://www.xoocode.org/

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message