ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: Locking in Project and PropertyHelper
Date Tue, 17 Jun 2008 12:57:23 GMT
On Tue, 17 Jun 2008, Stefan Bodewig <bodewig@apache.org> wrote:

> I suggest the following changes:
> 
> * lock the listener collection in the add/remove listener methods,
>   in fireMessageLogged lock the listeners, clone them, give up the
>   lock, work on the clone

alternatively copy listeners on change in the add/remove cases since
we are probably writing far more log messages than we add or remove
listeners.  Same would apply to the delegates in PropertyHelper.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message