Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Received-SPF: pass (athena.apache.org: domain of xavier.hanin@gmail.com
 designates 64.233.178.241 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=iUEjQPdWdupaBJau6Oj+gA1ap0PmhL7kkijUQCY+DdsnRZZIKeHoaIjvI2gbiy0c2DS/3Rq4AgFUqQFVtEUutISdhC9LJwSAoi7FbLPXJ0uS04jmNpI0AI44fhRElBF3DHy3fTy0Tu7e0A0pisT/iEquIFHzNgjk2k/mpa61qd0=
Message-ID: <635a05060802130112s46ea0998uc6b89d436d41be30@mail.gmail.com>
Date: Wed, 13 Feb 2008 10:12:21 +0100
From: "Xavier Hanin" <xavier.hanin@gmail.com>
To: "Ant Developers List" <dev@ant.apache.org>
Subject: Re: Store pom dependency Managment in extra data
In-Reply-To: <e9d8a2610802130010p70331730xee23a11914c03c24@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_28222_22276878.1202893941906"
References: <e9d8a2610802130010p70331730xee23a11914c03c24@mail.gmail.com>

------=_Part_28222_22276878.1202893941906
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Feb 13, 2008 9:10 AM, Gilles Scokart <gscokart@gmail.com> wrote:

> In the rewrite of the pom parser, I would like to store the maven
> dependency
> managment (and maybe also the properties) into the extra data of the
> moduleRevisionId.
>
> That way, the corresponding ivy module descriptor would contains all the
> info coming from the pom.  I think it might be usefull when it is
> serialized
> are reused from the cache (thought I'm not sure if it's the original pom
> or
> the serialized ivy.xml that is used in that case).
>
> However, I have noticed that the extra attributes are used to compare
> moduleRevisionId, and I fear that might bring some problem.  Does it?

Probably.


>  And
> is it normal to use the extra attributes in this comparison?

I think so, many time people use extra attributes in the info tag to add
extra identification attributes. I don't really think putty meta information
such as the dependency management information in extra attributes is a good
fit. But I like the idea of keeping data from dependency management section.
Maybe a good way to do it would be to add a Map of properties to the module
descriptor. This would be another area of flexibility for Ivy users, and I'd
even see usage for Ivy files, if we actually make them usable as properties
in the Ivy file. Something like:
<ivy-module version="2.0">
  <info org="foo" name="bar" />
  <property name="foo.baz.revision" value="1.0.4" />
  <dependencies>
    <dependency org="foo" name="baz-api" rev="${foo.baz.revision}" />
    <dependency org="foo" name="baz-main" rev="${foo.baz.revision}" />
    <dependency org="foo" name="baz-other" rev="${foo.baz.revision}" />
  </dependencies>
</ivy-module>

WDYT?

Xavier

>
>
> --
> Gilles Scokart
>


-- 
Xavier Hanin - Independent Java Consultant
http://xhab.blogspot.com/
http://ant.apache.org/ivy/
http://www.xoocode.org/

------=_Part_28222_22276878.1202893941906--