ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Petar Tahchiev" <paranoia...@gmail.com>
Subject Re: The Cactus/JUnit-Task problem
Date Tue, 19 Feb 2008 14:25:51 GMT
Hi everybody,

I am really, really sorry for my ignorance :-(.
I spent the whole day, trying to figure out what is
the reason for the vmCrashString to be null. And I found it,
actually :-). The reason was me :-). I unintentially was
adding the

        <dependency org="ant" name="ant-junit" rev="1.6.5"/>

to the classpath. After removing it, everything works just perfect.

Once again sorry, and you can feel free to apply the patch to
Ant 1.7.2 and Ant 1.8.

Cheers, Petar.

2008/2/19, Stefan Bodewig <bodewig@apache.org>:
>
> On Mon, 18 Feb 2008, Petar Tahchiev <paranoiabla@gmail.com> wrote:
>
> > Stefan, my patch was almost the same as your improved
> > version.
>
> OK, I've committed my changes as a first part.
>
> > However, my patch had these additional lines:
> >
> > @@ -1035,7 +1024,7 @@
> >              if (watchdog != null && watchdog.killedProcess()) {
> >                  result.timedOut = true;
> >                  logTimeout(feArray, test, vmCrashString);
> > -            } else if
> > (!Constants.TERMINATED_SUCCESSFULLY.equals(vmCrashString)) {
> > +            } else if
> > (!Constants.TERMINATED_SUCCESSFULLY.equals(vmCrashString) &&
> > vmCrashString != null) { result.crashed = true; logVmCrash(feArray,
> > test, vmCrashString);
> >              }
>
> No, that change would be wrong.
>
> Ant's TestRunner writes a file that will contain
> Constants.TERMINATED_SUCCESSFULLY if the TestRunner has run to
> completion.  This file will be empty or contains anything else if the
> forked VM has been terminated before writing the file.
>
> With your change we'd no longer detect crashed forked VMs.
>
> > As you can see I have added the && vmCrashString != null statement,
> > because cactus's tests seem to return null when the test is executed
> > successfully.
>
> Then we should try to find out why it is null when you run the tests
> from Cactus.
>
> How do you start the forked VM?
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>


-- 
Regards, Petar!
Karlovo, Bulgaria.

EOOXML Objections
http://www.grokdoc.net/index.php/EOOXML_objections

Public PGP Key at:
https://keyserver1.pgp.com/vkd/DownloadKey.event?keyid=0x19658550C3110611
Key Fingerprint: A369 A7EE 61BC 93A3 CDFF  55A5 1965 8550 C311 0611

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message