ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Petar Tahchiev" <paranoia...@gmail.com>
Subject Re: The Cactus/JUnit-Task problem
Date Mon, 18 Feb 2008 14:09:08 GMT
Hi all,

Stefan, my patch was almost the same as your improved version. However, my
patch had these
additional lines:

@@ -1035,7 +1024,7 @@
             if (watchdog != null && watchdog.killedProcess()) {
                 result.timedOut = true;
                 logTimeout(feArray, test, vmCrashString);
-            } else if
(!Constants.TERMINATED_SUCCESSFULLY.equals(vmCrashString)) {
+            } else if
(!Constants.TERMINATED_SUCCESSFULLY.equals(vmCrashString) && vmCrashString
!= null) {
                 result.crashed = true;
                 logVmCrash(feArray, test, vmCrashString);
             }


As you can see I have added the
&& vmCrashString != null
statement, because cactus's tests seem to return null when the test is
executed successfully.

With this one statement and your improved patch all works just perfect.


Kind regards, Petar.

2008/2/18, Stefan Bodewig <bodewig@apache.org>:
>
> On Sat, 16 Feb 2008, Petar Tahchiev <paranoiabla@gmail.com> wrote:
>
> > I have modified Stefan's patch just a little bit, so that now
> > everything works just perfect.
>
> Your patch didn't make it to the list.  Could you please take a
> look at my revised patch to verify it works for you?
>
> Thanks
>
>         Stefan
>



-- 
Regards, Petar!
Karlovo, Bulgaria.

EOOXML Objections
http://www.grokdoc.net/index.php/EOOXML_objections

Public PGP Key at:
https://keyserver1.pgp.com/vkd/DownloadKey.event?keyid=0x19658550C3110611
Key Fingerprint: A369 A7EE 61BC 93A3 CDFF  55A5 1965 8550 C311 0611

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message