ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xavier Hanin" <xavier.ha...@gmail.com>
Subject Re: IVY Checkstyle
Date Wed, 02 Jan 2008 16:57:58 GMT
Hi Markus,

Thanks a lot for your contribution. For the style fixes, could you attach
the patch to this issue:
https://issues.apache.org/jira/browse/IVY-511

It would clear out copyright issue.

For the checkstyle configuration change, it's very difficult to review your
change since the whole file is diffed. You may have change some invisible
characters, could you try to submit a diff with only the change you suggest?

And for the eclipse settings, it's useful to check them in so that we all
share the same defaults for license headers for example. Sometimes we have
to be careful with what we check in or not, but the trouble is worth the
advantages IMO.

Xavier

On Dec 29, 2007 11:04 PM, Markus M. May <mmay@gmx.net> wrote:

> Hello,
> I thought it is wothwhile to checkout some checkstlye stuff in Ivy. I
> de-activated the "Hide default constructor in Util Classes", because I
> got far too many false positives. Furthermore I activated the JAVADoc
> check, since I find Javadocs very helpful, if you are new to code.
> Furhtermore I already fixed some small checkstyle issues in the code
> already.
>
> Hope you find this helpful. Please note, that all changes, I made to
> the Eclipse settings are now in this diff as well. Probably we should
> take the eclipse settings out of the svn-repository?
>
> R,
>
> Markus
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>



-- 
Xavier Hanin - Independent Java Consultant
http://xhab.blogspot.com/
http://ant.apache.org/ivy/
http://www.xoocode.org/

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message