ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Xavier Hanin <Xavier.Ha...@sas.com>
Subject RE: extra attributes on publication artifacts
Date Fri, 07 Dec 2007 22:35:20 GMT
> -----Original Message-----
> From: Maarten Coene [mailto:maarten_coene@yahoo.com]
> Sent: Friday, December 07, 2007 5:25 PM
> To: Ant Developers List
> Subject: Re: extra attributes on publication artifacts
>
> It's a problem for fixing IVY-471 where I only want to write the extra-
> attributes for the published artifact that are really defined for that
> artifact (and not inherited from the module). In addition, I think it
> could confuse people when they define extra-attributes on the module
> and on the artifact with the same name -> which one will be taken? And
> at least, at the moment, there is a bug in this
> ArtifactRevisionId.newInstance(...) method which causes that the
> original extra-attributes on the artifact are lost.
>
> But I'll take a look at the example in IVY-418. If that one succeeds,
> I'll remove this piece of code that adds these extra attributes to the
> artifact, ok?
Allright for me. Even my theory about patterns is wrong since we merge the mrid and artifact
rev id attributes in the IvyPatternHelper, so I guess you can remove that safely.

Xavier

>
> Maarten
>
> ----- Original Message ----
> From: Xavier Hanin <Xavier.Hanin@sas.com>
> To: Ant Developers List <dev@ant.apache.org>
> Sent: Friday, December 7, 2007 11:16:15 PM
> Subject: RE: extra attributes on publication artifacts
>
>
> I guess it's more related to IVY-419 (which has been introduced for
>  maven 2 classifers, but is now an Ivy feature).
>
> IVY-419 let people define artifacts for a dependency even though the
>  dependendy already has a module descriptor. But maybe adding extra
>  attributes the the ArtifactRevisionId was only an attempt which end up
> being
>  unuseful. If no unit test fails, it's probably the reason. But we'd
>  need to make a real world test with a dependency on a mven 2 pom using
>  classifiers (there's one example in IVY-418).
>
> BTW, is it a source of problem for you?
>
> Xavier
>
>
> > -----Original Message-----
> > From: Maarten Coene [mailto:maarten_coene@yahoo.com]
> > Sent: Friday, December 07, 2007 5:04 PM
> > To: Ant Developers List
> > Subject: Re: extra attributes on publication artifacts
> >
> > No tests are failing if I remove it. The corresponding svn commit log
> > where this code has been added is this (svn revision 515753)
> >
> > NEW: define artifacts not declared by the dependency module
>  descriptor
> > (IVY-419)
> > FIX: Ivy doesn't recognize maven2 classifiers (IVY-418)
> >
> > Xavier: could you remember some more details? Maybe something with
> > these maven2 classifiers?
> >
> > Maarten
> >
> > ----- Original Message ----
> > From: Xavier Hanin <Xavier.Hanin@sas.com>
> > To: Ant Developers List <dev@ant.apache.org>
> > Sent: Friday, December 7, 2007 10:46:56 PM
> > Subject: RE: extra attributes on publication artifacts
> >
> >
> > I think it is useful to use them in patterns. Try removing this piece
> >  of code and see if a test case is failing, I wouldn't be surprised
>  we
> >  have a test case for that.
> >
> > Xavier
> >
> > > -----Original Message-----
> > > From: Maarten Coene [mailto:maarten_coene@yahoo.com]
> > > Sent: Friday, December 07, 2007 4:41 PM
> > > To: ant-dev
> > > Subject: extra attributes on publication artifacts
> > >
> > > Hi,
> > >
> > > In the ArtifactRevisionId.newInstance(...) methods, the extra
> > > attributes of the module are automatically added to the extra
> > > attributes of the module artifacts.
> > > Any idea what could be the reason for this?
> > >
> > > Maarten
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
>
> _______________________________________________________________________
> > > _____________
> > > Never miss a thing.  Make Yahoo your home page.
> > > http://www.yahoo.com/r/hs
> > >
> > >
>  ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> > > For additional commands, e-mail: dev-help@ant.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> > For additional commands, e-mail: dev-help@ant.apache.org
> >
> >
> >
> >
> >
> >
> >
> >
>
> _______________________________________________________________________
> > _____________
> > Be a better friend, newshound, and
> > know-it-all with Yahoo! Mobile.  Try it now.
> > http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> > For additional commands, e-mail: dev-help@ant.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
>
>
>
>
>
> _______________________________________________________________________
> _____________
> Never miss a thing.  Make Yahoo your home page.
> http://www.yahoo.com/r/hs
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message