ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martijn Kruithof <...@apache.org>
Subject Re: svn commit: r590990 - /ant/core/trunk/src/main/org/apache/tools/ant/util/WorkerAnt.java
Date Thu, 01 Nov 2007 21:18:49 GMT

>      public void waitUntilFinished(long timeout) throws InterruptedException {
>          synchronized(notify) {
> -            if(finished) {
> -                return;
> +            while (!finished) {
> +                notify.wait(timeout);
>              }
> -            notify.wait(timeout);
>          }
>      }
>   
I hope you noticed that this is not an equivalent change, not just 
starting to accepting "false" interrupts, but also to ignore the timeout.

to do it correctly probably it should be using something using 
currentTimeMillis as well.


Martijn

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message