Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Received-SPF: pass (athena.apache.org: domain of peter.kitt.reilly@gmail.com
 designates 209.85.146.179 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=MWM9JfngTGNyBKgahq9+FftNs0zVfWAvm/Wr1jhlsgdIqpDYdoXMl2IAmTtiD16skrHl0yfhA3caNnKMRgzCSQFHSKu15dYFs+eS7/ANQbgRWS3b6otrIIvYSpF1A6PDtqo3CRWLBP/Pc6IkzpUdJl7Rk4uVBZWDy9r1kr4MJaY=
Message-ID: <dffc72020709280855o6b35365csfb5642d52f7f4080@mail.gmail.com>
Date: Fri, 28 Sep 2007 16:55:22 +0100
From: "Peter Reilly" <peter.kitt.reilly@gmail.com>
To: "Ant Developers List" <dev@ant.apache.org>
Subject: Re: svn commit: r580302 -
 /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java
In-Reply-To: <46FD1D78.2040005@mdl.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20070928111319.D9C0B1A9832@eris.apache.org>
	 <46FD1D78.2040005@mdl.com>

On 9/28/07, Alexey Solofnenko <A.Solofnenko@mdl.com> wrote:
> In general, I do not see a reason to replace perfectly readable single
> liners with several lines of code - it just increases code bloat.

We agreed to use the checkstyle config
(src/etc/checkstyle/checkstyle-config) for ant
 about 2 years ago.
This does ban inner assignments.

> Anybody with high IQ should be able to read old code as is.
- provided one scans it a number of times.
We write enough so the complicated code can be used for complicated
problems - not simple problems.
I am of the firm belief that code should be as simple as possible (but
not simpler!).
This means small methods, "near" variables, small single purpose classes,
one action per statement, quick exit/fail, all statements at the same
level of abstraction,
handling of exceptions in "control" classes.

> In this case
> the change is warranted, but please move "is" variable and try/finally
> inside "else" - the scoping is wrong now.

The scoping has not changed, but is now more obvious......
I have made the change.

Peter

>
> - Alexey.
>
> peterreilly@apache.org wrote:
> > Author: peterreilly
> > Date: Fri Sep 28 04:13:19 2007
> > New Revision: 580302
> >
> > URL: http://svn.apache.org/viewvc?rev=580302&view=rev
> > Log:
> > checkstyle: remove inner assignment
> >
> > Modified:
> >     ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java
> >
> > Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java
> > URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java?rev=580302&r1=580301&r2=580302&view=diff
> > ==============================================================================
> > --- ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java (original)
> > +++ ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java Fri Sep 28 04:13:19 2007
> > @@ -130,8 +130,12 @@
> >      public boolean isExists() {
> >          InputStream is = null;
> >          try {
> > -            return isReference() ? ((Resource) getCheckedRef()).isExists()
> > -                : (is = getInputStream()) != null;
> > +            if (isReference()) {
> > +                return  ((Resource) getCheckedRef()).isExists();
> > +            } else {
> > +                is = getInputStream();
> > +                return is != null;
> > +            }
> >          } catch (IOException ex) {
> >              return false;
> >          } finally {
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> > For additional commands, e-mail: dev-help@ant.apache.org
> >
>
> --
> ------------------------------------------------------------------------
> Alexey N. Solofnenko <http://trelony.cjb.net/>
> Pleasant Hill, CA (GMT-8 usually)
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org