Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Received-SPF: pass (athena.apache.org: domain of peter.kitt.reilly@gmail.com
 designates 209.85.198.190 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=ABXqh8g4Rsi5jw9uCZjwvhohFCHG00rroXc0+3Veer032FgXpM6xSo+cD2k2vuY2XyWtJFlH8wZYmxFWudkl18jc2WIry2jbRrX7ioMiI36lcrLAwdNSJ9oxs7aVjR+MUOKrJi0jx26A5oIeTa/RvRAEJ8K3yEFoawXObk0TKPs=
Message-ID: <dffc72020709210133i4a02978by60d67d1b59b58b0f@mail.gmail.com>
Date: Fri, 21 Sep 2007 09:33:31 +0100
From: "Peter Reilly" <peter.kitt.reilly@gmail.com>
To: "Ant Developers List" <dev@ant.apache.org>
Subject: Re: AW: ant really slow, 100% CPU?
In-Reply-To: <46F29168.6060404@apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <EF39D77A486C234B9D9933091CE6D21E020F84AA@z011034.bk.fin.local>
	 <46F12A94.6070107@apache.org> <46F27B02.3080200@apache.org>
	 <255d8d690709200819i5e58f92bh7e2ea08a289187ab@mail.gmail.com>
	 <46F29168.6060404@apache.org>

1) Some of the traces seem to imply a bug.
org.apache.tools.ant.taskdefs.Property$PropertyResolver.evaluate(Property.java:110)
        at
org.apache.tools.ant.PropertyHelper.getProperty(PropertyHelper.java:787)
        - locked <0x00002aaab4013548> (a
org.apache.tools.ant.PropertyHelper)
        at
org.apache.tools.ant.PropertyHelper.parseNextProperty(PropertyHelper.java:541)
        at
org.apache.tools.ant.PropertyHelper.parseProperties(PropertyHelper.java:502)
        at
org.apache.tools.ant.RuntimeConfigurable.maybeConfigure(RuntimeConfigurable.java:390)
The intent of Property.PropertyResolver is I think to remain in
the Property task - the trace seems to imply that it has
escaped from that task.

2) some of the new code seems to be very inefficent:
    private void resolveAllProperties(Map props) throws BuildException {
        PropertyHelper propertyHelper = (PropertyHelper)
PropertyHelper.getPropertyHelper(
                getProject()).clone();
        propertyHelper.add(new PropertyResolver(props));
This means that when one does <property env=".."/>, for
each env variable, the propertyhelper is cloned.

3) The reason for this is to allow different property demarcations -
using ProperyExpander's.
 The use-case for this is to allow "${${a}-${b}}" type expansion (this is
a much requested enhancement).

and in something like a properties file:

action=cut
cut=the cut action
do=the action is ${${action}}
paste=the paste action

can get difficult to parse. The new code
does this is a nice way (except for the
ThreadLocal).

Peter
On 9/20/07, Steve Loughran <stevel@apache.org> wrote:
> Dominique Devienne wrote:
> > On 9/20/07, Steve Loughran <stevel@apache.org> wrote:
> >> it appears to hang at 100% CPU during gzip
> >>
> >> release.gzip-rpm:
> >>        [tar] Building tar: ...
> >>       [gzip] Building:.../smartfrog-rpm-bundle-3.12.003dev.gz
> >>
> >> through the miracle that is kill -QUIT, here's the thread dump
> >
> > Did I miss the gzip task in the stack trace? In both dumps you
> > provided, I see only property stuff, so how does that relate to
> > gzip??? Thanks, --DD
> >
>
> nothing, its just after that task that everything seems to lock up.
>
> But sometimes it jams in other places; other times it just keeps going.
> That is all the sign of race conditions to me: inconsistent behaviour
It appears that the new code for
> --
> Steve Loughran                  http://www.1060.org/blogxter/publish/5
> Author: Ant in Action           http://antbook.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org