Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Received-SPF: pass (athena.apache.org: domain of peter.kitt.reilly@gmail.com
 designates 209.85.146.181 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=W+NACxIfwb3XUnj+tfX7NMcMcsofu7QldQj8+x/Oy8s6IQmfwaz1hfyT3Ei471vkmR8YyMS0RO2iq98SQMjPxptmbJODe5PIZ7T35MSG3qdih8MH8QKVqaUGQ9brKw7O9Gj0y+j2SOxF2Lm0siBZInAra1TS5lW558GJYxNVs0E=
Message-ID: <dffc72020709200359g4deb2329rff68d3181b583802@mail.gmail.com>
Date: Thu, 20 Sep 2007 11:59:19 +0100
From: "Peter Reilly" <peter.kitt.reilly@gmail.com>
To: "Ant Developers List" <dev@ant.apache.org>
Subject: Re: svn commit: r577308 - in
 /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs: ProcessDestroyer.java
 RecorderEntry.java Redirector.java Sleep.java StreamPumper.java Tar.java
 Zip.java
In-Reply-To: <EF39D77A486C234B9D9933091CE6D21E020F84AD@z011034.bk.fin.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <EF39D77A486C234B9D9933091CE6D21E020F84AD@z011034.bk.fin.local>

Yes, It is difficult to come up with good names....

When I see wait(1000), my brain translates this it wait
for a signal, but if it does not happen in a second,
give up.

So in this case, one second as a name sounds reasonable
(or at least better than 1000).

Peter


On 9/20/07, Jan.Materne@rzf.fin-nrw.de <Jan.Materne@rzf.fin-nrw.de> wrote:
> >URL: http://svn.apache.org/viewvc?rev=577308&view=rev
> >Log: more magic numbers
> >
> >
> >Modified:
> >ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/ProcessDestroyer.
> java
> > class ProcessDestroyer implements Runnable {
> >-
> >+    private static final int TWENTY_SECONDS = 20000;
> >     private Vector processes = new Vector();
> >     // methods to register and unregister shutdown hooks
> >     private Method addShutdownHookMethod;
> >             try {
> >-                destroyProcessThread.join(20000);
> >+                destroyProcessThread.join(TWENTY_SECONDS);
>
>
> You should use the meaning of the constant as name, not its value.
>
>
> >Modified:
> >ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Redirector.java
> > public class Redirector {
> >+    private static final int ONE_SECOND = 1000;
> >
> >     private static final String DEFAULT_ENCODING
> >         = System.getProperty("file.encoding");
> >-                wait(1000);
> >+                wait(ONE_SECOND);
>
>
> again - describe the meaning not the value
>
>
> >ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/StreamPumper.java
> (original)
> > public class StreamPumper implements Runnable {
> >
> >+    private static final int SMALL_BUFFER_SIZE = 128;
> >-    private int bufferSize = 128;
> >+    private int bufferSize = SMALL_BUFFER_SIZE;
>
>
> exactly like here. Its not HUNDRED_TWENTY_EIGHT, it is SMALL_BUFFER_SIZE
> ;)
>
>
> Jan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org