From dev-return-80855-apmail-ant-dev-archive=ant.apache.org@ant.apache.org Wed Sep 26 12:37:45 2007 Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 51679 invoked from network); 26 Sep 2007 12:37:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 26 Sep 2007 12:37:21 -0000 Received: (qmail 88042 invoked by uid 500); 26 Sep 2007 12:37:10 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 88003 invoked by uid 500); 26 Sep 2007 12:37:10 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 87992 invoked by uid 99); 26 Sep 2007 12:37:10 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Sep 2007 05:37:10 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [193.109.238.66] (HELO dnsinet.rzf-nrw.de) (193.109.238.66) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Sep 2007 12:39:28 +0000 Received: from z011100.bk.fin.local (z011100.bk.fin.local [172.18.101.140]) by dnsinet.rzf-nrw.de (8.14.0/8.14.0) with ESMTP id l8QCajjA029972 for ; Wed, 26 Sep 2007 14:36:45 +0200 Received: from z011034.bk.fin.local ([130.11.7.34]) by z011100.bk.fin.local with Microsoft SMTPSVC(6.0.3790.0); Wed, 26 Sep 2007 14:36:54 +0200 X-MimeOLE: Produced By Microsoft Exchange V6.5.7226.0 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: AW: svn commit: r579266 - in /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/ssh: ScpFromMessage.java ScpFromMessageBySftp.java ScpToMessage.java ScpToMessageBySftp.java Date: Wed, 26 Sep 2007 14:36:45 +0200 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: svn commit: r579266 - in /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/ssh: ScpFromMessage.java ScpFromMessageBySftp.java ScpToMessage.java ScpToMessageBySftp.java Thread-Index: AcgAMjegH9FDRaY+Q3e7swbXgi096AAB5y0w From: To: X-OriginalArrivalTime: 26 Sep 2007 12:36:54.0560 (UTC) FILETIME=[EB94EA00:01C80039] X-Virus-Checked: Checked by ClamAV on apache.org >> What about pulling the HUNDRED_KILOBYTES constant to=20 >AbstractSshMessage and make it protected? >Or public. > >> Or using a utility class holding these constants? >This has some history, It is my fourth time trying to remove the >magic numbers. Each of the other times, I used a magic numbers class, >or classes, but had a problem in that I found it too easy to make mistakes >and the code was not easy to read. This time, I decided to do a file at >at time, use //CheckStyle:*** OFF at places where I could not figure >a good name (for example 3, 4, 0x3f, etc) and only do a small number for each commit >so that other people could see if the changes were correct. :) >Any silliness can be refactored later. ok Jan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org