ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@yahoo.com>
Subject Re: Rev 568096 breaks ant-contrib
Date Thu, 06 Sep 2007 19:13:59 GMT

--- Stefan Bodewig <bodewig@apache.org> wrote:

> On Wed, 05 Sep 2007, Stefan Bodewig
> <bodewig@apache.org> wrote:
> 
> > Instead of what we have in Equals it should
> probably be
> > 
> > public void setArg1(Object a) {
> >     if (a instanceof String) {
> >         setArg1((String) a);
> >     } else {
> >         somePrivateArg1Setter(a);
> >     }
> > }
> > 
> > public void setArg1(String a) {
> >     somePrivateArg1Setter(a);
> > }
> 
> Is anything wrong with that approach?

I had to go back and fully understand what was going
on, but I see now what you're doing with this
change... yes, it does seem like this could solve the
BC issue here.

Although I actually can't see any reason why IsGreater
extends Equals anyway, but once again, that would
theoretically be a BC issue for ac if they took it out
now.  Anyway, I forgive you, Dale... ;)  Or if I've
missed some obvious reason for the inheritance, you
can forgive me!

-Matt

> 
> Stefan
> 
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org
> For additional commands, e-mail:
> dev-help@ant.apache.org
> 
> 



       
____________________________________________________________________________________
Boardwalk for $500? In 2007? Ha! Play Monopoly Here and Now (it's updated for today's economy)
at Yahoo! Games.
http://get.games.yahoo.com/proddesc?gamekey=monopolyherenow  

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message