ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Solofnenko" <trel...@gmail.com>
Subject Re: svn commit: r557013 - in /ant/core/trunk/src/main/org/apache/tools/ant: AntClassLoader.java ComponentHelper.java
Date Tue, 17 Jul 2007 19:12:46 GMT
I also like ?: because they reduce the bloat, however ,for readability, it
is better to enclose them in parentheses.

- Alexey.

On 7/17/07, Matt Benson <gudnabrsam@yahoo.com> wrote:
>
>
> --- Peter Reilly <peter.kitt.reilly@gmail.com> wrote:
>
> > Hi Matt,
> > Is is necessary to apply these formatting changes at
> > the
> > moment?
>
> I suppose I can revert, read onward:
>
> > Normally when a branch is set up, there will be a
> > lot of
> > merging from the branch to the MAIN as minor bugs
> > get
> > fixed and having formatting changes can make it
> > difficult
> > to manage the merging.
>
> I can concede this...
>
> >
> > Also some of the changes are not directed by
> > checkstyle-config.
> > - I do not like removing of () as not having these
> > can make code
> >   difficult to read - my head hurts trying to figure
> > out precedence
>
> I didn't notice any that seemed terribly important,
> apologies...
>
> > - it not nice to increase line length above 80
> > characters.
>
> Then why did we change our checkstyle config to allow
> 100 max?
>
> > - replacing if with the horrid :? is also not nice.
>
> "horrid" == opinion IMO... I tend to use these to
> ruthlessly obliterate duplicate code, but I can revert
> these changes if effigy is on the table...
>
> -Matt
>
> >
> > Peter
> >
> >
>


-- 
Alexey N. Solofnenko
Home: http://trelony.cjb.net/
Pleasant Hill, CA (GMT-8 usually)

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message