From dev-return-79589-apmail-ant-dev-archive=ant.apache.org@ant.apache.org Thu Jun 14 17:02:57 2007 Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 47612 invoked from network); 14 Jun 2007 17:02:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Jun 2007 17:02:56 -0000 Received: (qmail 80103 invoked by uid 500); 14 Jun 2007 17:02:58 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 80069 invoked by uid 500); 14 Jun 2007 17:02:58 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 80058 invoked by uid 99); 14 Jun 2007 17:02:58 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jun 2007 10:02:58 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of peter.kitt.reilly@gmail.com designates 209.85.134.188 as permitted sender) Received: from [209.85.134.188] (HELO mu-out-0910.google.com) (209.85.134.188) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jun 2007 10:02:53 -0700 Received: by mu-out-0910.google.com with SMTP id w8so639335mue for ; Thu, 14 Jun 2007 10:02:32 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=G93R1huitxg3vnbnOoOWOGhISXNynMzXzc232l2d4phBK6RoqqiunLSphnHeyZQI1SrLkj8u42tkj+7heF8Of3YRKHXnOzTvwxuQ386ke6Tow3yee5y3Ohhk0DTcaj1FfLmNAN39fZN57vAF/jO2g1Cc9I/lO0Ceh+Lp9kHfKBI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=N9MfUYjJrjCCLQ8lebJgeDLq1LAPXTUegGN9g4Gj5wkGJbFB1JnO6R9scCzucdJwoyByfW9MQKocEUehlIFKxkDGOE7Q7uLvafHpenVavvcjEd+ZEYpWkM8b1IYcUId+ivqrO6oXIdAXULVCJwERHFrR2QDqFOlQzmuSNnu0raI= Received: by 10.82.178.11 with SMTP id a11mr3788924buf.1181840549228; Thu, 14 Jun 2007 10:02:29 -0700 (PDT) Received: by 10.82.120.12 with HTTP; Thu, 14 Jun 2007 10:02:29 -0700 (PDT) Message-ID: Date: Thu, 14 Jun 2007 18:02:29 +0100 From: "Peter Reilly" To: "Ant Developers List" Subject: Re: PropertyHelper thoughts In-Reply-To: <729402.2636.qm@web55103.mail.re4.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <590316.77790.qm@web55113.mail.re4.yahoo.com> <729402.2636.qm@web55103.mail.re4.yahoo.com> X-Virus-Checked: Checked by ClamAV on apache.org On 6/14/07, Matt Benson wrote: > Urgh, looking over the PropertyHelper stuff, I wonder > if we shouldn't refactor it somewhat. It seems to be > overly complex to allow full PropertyHelper delegates. Yes it is overly complex. (and full of bugs - esp with regard to child projects) > It seems that we might be better off using a single > PropertyHelper (still replaceable) and adding Lists of > getPropertyResolvers and setPropertyResolvers. This would be the way to go. Perhaps something like: interface GetPropertyResolver { String resolve(Project a, String property); // return null if not resolved } interface SetPropertyResolver { boolean setProperty(Project a, String property, String value) returns true if property consumed return false if not } Peter > One > obvious problem of the current implementation seems to > be that you can't do this: > > > > > > > > ${foo:1,1} > > Because the PH that knows how to handle the extended > syntax wasn't around when "foo" was set and thus won't > know about the foo property (I could be wrong but this > is my impression of what the code is doing). This > seems broken and extremely counter-intuitive to me. I > am going to look into an extensive refactor of PH and > if we determine that necessitates 1.8, well, so be it. > :| > > -Matt > > [SNIP] > > > > > ____________________________________________________________________________________ > Be a better Heartthrob. Get better relationship answers from someone who knows. Yahoo! Answers - Check it out. > http://answers.yahoo.com/dir/?link=list&sid=396545433 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org > For additional commands, e-mail: dev-help@ant.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org