Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Received-SPF: pass (herse.apache.org: domain of foamdino@gmail.com designates
 66.249.92.172 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=QmrH18aApN7Jsu21sVq2D6ips2nK9QbrhrN8YbHUXe1SAcVqxgO4+uKrf7VIx2ihQqBJlfa8Vk3jkq+XwRjnBTzSF2rfKfFHF3QOKqxy9tr5eJuBbGS0PjEatJ0JdFlX0d/EMzX+get9a3gmI1LMxOTgCM57SISoBG+uiJz8AUI=
Message-ID: <ab8e556c0705180139p426d9a6ak234f481dd877d0d5@mail.gmail.com>
Date: Fri, 18 May 2007 15:39:24 +0700
From: "Kevin Jackson" <foamdino@gmail.com>
To: "Ant Developers List" <dev@ant.apache.org>
Subject: Re: Retry task available in svn head
In-Reply-To: <EF39D77A486C234B9D9933091CE6D21EDAF4D5@z011034.bk.fin.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <EF39D77A486C234B9D9933091CE6D21EDAF4D5@z011034.bk.fin.local>

Hi Jan,
> If the nested task does not fail, the loop must be finished.
>
> +    public void execute() throws BuildException {
> +        for(int i=0; i<=retryCount; i++) {
> +            try {
> +                nestedTask.perform();

yes there should be a break; here - I will update as soon as eclipse
has stopped doing some updating

> +            } catch (Exception e) {
> +                if (i<retryCount) {
> +                    log("Attempt ["+i+"] error occured, retrying...", e, Project.MSG_INFO);
> +                } else {
> +                    throw new BuildException("Task ["+nestedTask.getTaskName()+"] failed after ["+retryCount+"] attempts, giving up");
> +                }
> +            }
> +        }
> +    }

Thanks for the catch, just shows that I don't have very good unit
tests, have to add that one.

Kev

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org