Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Received-SPF: pass (herse.apache.org: local policy)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Subject: AW: Retry task available in svn head
Date: Mon, 21 May 2007 08:29:01 +0200
Message-ID: <EF39D77A486C234B9D9933091CE6D21EDAF4F1@z011034.bk.fin.local>
Thread-Topic: Retry task available in svn head
Thread-Index: AceZ77mUw40yB2+ORJCLlRVphQY6qABfSwbw
From: <Jan.Materne@rzf.fin-nrw.de>
To: <dev@ant.apache.org>

>+            } catch (Exception e) {
>+                if (i<retryCount) {
>+                    log("Attempt ["+i+"] error occured, retrying...",
e, Project.MSG_INFO);
>+                } else {
>+                    throw new BuildException("Task
["+nestedTask.getTaskName()+"] failed after ["+retryCount+"] attempts,
giving up");
>+                }
>+            }
>
>I do not know very much about ant exception handling in general.
>So it seems to me that e is lost in some cases and I think it=20
>is not a good idea.

Would this be more useful?

    public void execute() throws BuildException {
        StringBuffer errorMessages =3D new StringBuffer();
        for(int i=3D0; i<=3DretryCount; i++) {
            try {
                nestedTask.perform();
                break;
            } catch (Exception e) {
                if (i<retryCount) {
                    log("Attempt ["+i+"] error occured, retrying...", e,
Project.MSG_INFO);
                    errorMessages.append(e.getMessage());
=20
errorMessages.append(getProject().getProperty("line.separator"));
                } else {
                    errorMessages.append(e.getMessage());
                    StringBuffer exceptionMessage =3D new =
StringBuffer();
                    exceptionMessage.append("Task
[").append(nestedTask.getTaskName());
                    exceptionMessage.append("] failed after
[").append(retryCount);
                    exceptionMessage.append("] attempts, giving up.");
=20
exceptionMessage.append(getProject().getProperty("line.separator"));
                    exceptionMessage.append("Error
messages:").append(getProject().getProperty("line.separator"));
                    exceptionMessage.append(errorMessages);
                    throw new
BuildException(exceptionMessage.toString(), getLocation());
                }
            }
        }
    }


  <target name=3D"test-fail-and-retry">
    <property name=3D"i" value=3D"3"/>
    <property name=3D"dest" value=3D"${java.io.tmpdir}/dest"/>
    <!-- just in case this ever becomes a legit url... -->
    <property name=3D"src" value=3D"http://iojasodjojaosdj"/>
      <retry retrycount=3D"${i}">
        <get src=3D"${src}" dest=3D"${dest}"/>
      </retry>
  </target>


test-fail-and-retry:
      [get] Getting: http://iojasodjojaosdj
      [get] To: c:\temp\dest
      [get] Error getting http://iojasodjojaosdj to c:\temp\dest
    [retry] Attempt [0] error occured, retrying...
      [get] Getting: http://iojasodjojaosdj
      [get] To: c:\temp\dest
      [get] Error getting http://iojasodjojaosdj to c:\temp\dest
    [retry] Attempt [1] error occured, retrying...
      [get] Getting: http://iojasodjojaosdj
      [get] To: c:\temp\dest
      [get] Error getting http://iojasodjojaosdj to c:\temp\dest
    [retry] Attempt [2] error occured, retrying...
      [get] Getting: http://iojasodjojaosdj
      [get] To: c:\temp\dest
      [get] Error getting http://iojasodjojaosdj to c:\temp\dest

BUILD FAILED
C:\TEMP\retry-test.xml:9: Task [get] failed after [3] attempts, giving
up.
Error messages:
java.net.UnknownHostException: iojasodjojaosdj
java.net.UnknownHostException: iojasodjojaosdj
java.net.UnknownHostException: iojasodjojaosdj
java.net.UnknownHostException: iojasodjojaosdj


Jan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org