ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@yahoo.com>
Subject Re: svn commit: r537344 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/condition/ResourceContains.java
Date Mon, 21 May 2007 16:34:59 GMT

--- Kevin Jackson <foamdino@gmail.com> wrote:

> > Hi guys.  Sorry I've been having trouble keeping
> up
> > lately.  Saw this stuff but missed the intervening
> > discussion.  Started playing today with adding
> refid
> > support, etc., but after awhile it occurred to me
> that
> > we already had this covered, e.g.:
> >
> > <resourcecount count="1">
> >   <restrict>
> >     <file file="${file}" />
> >     <contains text="text" casesensitive="false"
> >
> >
>
xmlns="antlib:org.apache.tools.ant.types.resources.selectors"
> > />
> >   </restrict>
> > </resourcecount>
> >
> > Note that this approach supports any resource type
> > right off the bat.  Actually with the suggested
> "add"
> > idiom, <resourcecontains> should be rewritten as a
> > macrodef.  :|
> 
> Well that's definitely simpler than having a custom
> task in Java! I
> think that's probably the way to go as we already
> have the basic
> building blocks available.

Back to this... do we plan to replace
au:assertResourceContains with some usage of the
<contains> selector as I demonstrated, then remove the
ResourceContains java condition?

-Matt

> 
> Kev
> 
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org
> For additional commands, e-mail:
> dev-help@ant.apache.org
> 
> 



      ____________________________________________________________________________________
Park yourself in front of a world of choices in alternative vehicles. Visit the Yahoo! Auto
Green Center.
http://autos.yahoo.com/green_center/ 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message