Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Received-SPF: pass (herse.apache.org: domain of foamdino@gmail.com designates
 66.249.92.172 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=XDzGNFZ/yZujpAk9BbLbu+iWd9RI0LcKvOqIX3EOMJoTRgUsVyj/qY8HNSpUlt2jP36Zc97gBYHRFEfmFYdFhTK2+J/MkHX/N9YWmlwIGSuMDn27IrRsZYmU1dstCEfsat3s8TLemCmO8wleGRTWHHlP48umqxjEMlAH6X+/CDE=
Message-ID: <ab8e556c0704231922oc094ffate3fd7c5ba569ed69@mail.gmail.com>
Date: Tue, 24 Apr 2007 09:22:11 +0700
From: "Kevin Jackson" <foamdino@gmail.com>
To: "Ant Developers List" <dev@ant.apache.org>
Subject: Re: svn commit: r531472 -
 /ant/core/trunk/src/tests/antunit/taskdefs/condition/hasfreespace-test.xml
In-Reply-To: <20070423141150.DC95D1A983E@eris.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20070423141150.DC95D1A983E@eris.apache.org>

Hi all,

Sorry about this one, I should have thought of using ${user.home} for
the tests instead of hard-coded c:

Good catch Steve

Kev

On 4/23/07, stevel@apache.org <stevel@apache.org> wrote:
> Author: stevel
> Date: Mon Apr 23 07:11:46 2007
> New Revision: 531472
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=531472
> Log:
> Test didnt work on Unix. Assume that ${user.home} is in a partition with some (but finite) space. If anyone runs these tests on a disk array with >1 petabyte, they will still fail.
>
> Modified:
>     ant/core/trunk/src/tests/antunit/taskdefs/condition/hasfreespace-test.xml
>
> Modified: ant/core/trunk/src/tests/antunit/taskdefs/condition/hasfreespace-test.xml
> URL: http://svn.apache.org/viewvc/ant/core/trunk/src/tests/antunit/taskdefs/condition/hasfreespace-test.xml?view=diff&rev=531472&r1=531471&r2=531472
> ==============================================================================
> --- ant/core/trunk/src/tests/antunit/taskdefs/condition/hasfreespace-test.xml (original)
> +++ ant/core/trunk/src/tests/antunit/taskdefs/condition/hasfreespace-test.xml Mon Apr 23 07:11:46 2007
> @@ -2,29 +2,32 @@
>  <project name="hasfreespace-test" default="all" basedir="." xmlns:au="antlib:org.apache.ant.antunit">
>
>    <available property="jdk6.available" classname="java.util.ServiceLoader"/>
> -
> +
> +  <property name="partition" value="${user.home}" />
> +
> +
>    <target name="test-not-enough-space-human" if="jdk6.available">
>      <au:assertFalse>
> -      <hasfreespace partition="c:" needed="1P"/>
> +      <hasfreespace partition="${partition}" needed="1P"/>
>      </au:assertFalse>
>    </target>
>
>    <target name="test-enough-space-human" if="jdk6.available">
>      <au:assertTrue>
> -      <hasfreespace partition="c:" needed="1K"/>
> +      <hasfreespace partition="${partition}" needed="1K"/>
>      </au:assertTrue>
>    </target>
>
>    <target name="test-not-enough-space" if="jdk6.available">
>         <property name="long.max-value" value="9223372036854775807"/>
>      <au:assertFalse>
> -         <hasfreespace partition="c:" needed="${long.max-value}"/>
> +         <hasfreespace partition="${partition}" needed="${long.max-value}"/>
>      </au:assertFalse>
>    </target>
>
>    <target name="test-enough-space" if="jdk6.available">
>      <au:assertTrue>
> -      <hasfreespace partition="c:" needed="1"/>
> +      <hasfreespace partition="${partition}" needed="1"/>
>      </au:assertTrue>
>    </target>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org