ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Solofnenko" <trel...@gmail.com>
Subject Re: DO NOT REPLY [Bug 42219] - Inefficient code in Union, DirectoryScanner makes large copy tasks very slow
Date Thu, 26 Apr 2007 16:33:43 GMT
I would use inheritance instead of facades.

- Alexey.

On 4/26/07, Steve Loughran <stevel@apache.org> wrote:
>
> Alexey N. Solofnenko wrote:
> > Classpath ordering is a usual practice that is used, for example, for
> > patching.
>
> yes, and it doesnt work with signed JARs. And, because <fileset> doesnt
> impose an order, you can't guarantee the order of use.
>
>
>   The same classpath order could be used in debugger too. In our
> > case it could be hidden inside launcher. But there are other ways to
> > achieve the same - for example, factories that can return Java6 specific
> > FileResource, but it is cumbersome:
> > (FileResource)project.createObject("org.apache....FileResource"). The
> > later has its advantages too - project could configure the class to
> > support permissions or not.
>
> Facades, all you need are facades. More indirection.
>
>
> >
> > This follows to settings. I think we could put the settings in the
> > project class (as get/set methods or somehow else) - support or not
> > permissions, old/new behaviour is not a property of the environment, but
> > it is a property of a specific build script.
>
> hmmm.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>


-- 
Alexey N. Solofnenko
Home: http://trelony.cjb.net/
Pleasant Hill, CA (GMT-8 usually)

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message