ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Jackson" <foamd...@gmail.com>
Subject Re: svn commit: r518896 - /ant/core/trunk/src/main/org/apache/tools/ant/util/FileUtils.java
Date Fri, 16 Mar 2007 10:21:06 GMT
Hi Peter,

> Please rollback this change.
> It is a misuse of reflection.
>

Why do you say it's a mis-use of reflection - the code was duplicated
and using reflection we can remove the duplication, keep the interface
the same and have the same behaviour as before.  There may be a small
amount of method-call overhead because of the use of reflection - but
again I don't see this as a misuse

Kev

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message