ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Loughran <ste...@apache.org>
Subject Re: Two good patches for mysql support and generic sql row counting
Date Mon, 04 Dec 2006 15:01:19 GMT
Hunter Peress wrote:
> I submitted two patches a month ago and I would like to know if any of the
> developers wouldnt mind adding it to a forthcoming release.
> 
> One of the patches returns the count of the result rows in an efficient
> manner. The other adds support for mysql which is especially useful when
> sourcing mysqldump files from version 5.0 and greater.
> 
> Thanks!
> 
> http://issues.apache.org/bugzilla/show_bug.cgi?id=40923
> http://issues.apache.org/bugzilla/show_bug.cgi?id=40922
> 


I do agree that we need to improve the SQL task, but think its too late 
to get into the 1.7.0 release. this is something that would be good in a 
1.7.1 timeframe, *after* we have a decent set of tests for the sql task, 
so that we can be sure that changes dont break anything.

to put differently: the first thing we have to add to SQL, before 
anything else, is some tests to verify the current functionality.

FWIW, I have been doing bits of this @work in the smartfrog database 
components, that are based on the SQL task, albeit without any comment 
support, and without the where-does-the-line end problem, which I solved 
by requiring the statements to come as a list:


  CreateUser extends AdminCommand {
     username TBD;
     password TBD;
     sqlCommands [
      (("CREATE USER " ++ username ) ++ (" PASSWORD " ++ password)),
      "DROP TABLE events"
     ];
  }

We could use the SQL I have there (which works with hsqldb) together 
with the code to read the database results as the test base.

As usual, I no free time to do this right now...

-steve

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message