Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 60954 invoked from network); 17 Nov 2006 03:10:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Nov 2006 03:10:30 -0000 Received: (qmail 69554 invoked by uid 500); 17 Nov 2006 03:10:39 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 69484 invoked by uid 500); 17 Nov 2006 03:10:39 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 69472 invoked by uid 99); 17 Nov 2006 03:10:39 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Nov 2006 19:10:39 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of jak-ant-dev@m.gmane.org designates 80.91.229.2 as permitted sender) Received: from [80.91.229.2] (HELO ciao.gmane.org) (80.91.229.2) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Nov 2006 19:10:25 -0800 Received: from root by ciao.gmane.org with local (Exim 4.43) id 1Gku78-0003Tv-GQ for dev@ant.apache.org; Fri, 17 Nov 2006 04:10:02 +0100 Received: from c-66-30-204-182.hsd1.ma.comcast.net ([66.30.204.182]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 17 Nov 2006 04:10:02 +0100 Received: from jesse.glick by c-66-30-204-182.hsd1.ma.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 17 Nov 2006 04:10:02 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: dev@ant.apache.org From: Jesse Glick Subject: Re: svn commit: r475078 - /ant/core/trunk/src/main/org/apache/tools/ant/types/optional/depend/DependScanner.java Date: Thu, 16 Nov 2006 22:00:49 -0500 Organization: Sun Microsystems / NetBeans Lines: 41 Message-ID: References: <20061115001138.CE9FC1A984D@eris.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: c-66-30-204-182.hsd1.ma.comcast.net User-Agent: Thunderbird 1.5.0.8 (X11/20061107) In-Reply-To: Sender: news X-Virus-Checked: Checked by ClamAV on apache.org Peter Reilly wrote: >> Note that you can simply delete the Javadoc comment altogether: > > Yes, I know, but 1) checkstyle does not So shouldn't you patch checkstyle? :-) > 2) javadoc will check that there is doc to inherit when one puts in inheritDoc. But checkstyle would already be warning you about any lack of superclass Javadoc anyway, right? (Unless you have a method in a public class overriding a method in an inaccessible class. Which IMHO is evil.) > Having comments for get/set is especially tedious. Yes, it is. Don't think there's anything to be done about it, other than avoiding the beans pattern in APIs to begin with. > Do not know about the trailling dot...... /** {@inheritDoc}. */ vs. /** {@inheritDoc} */ > Yes, as the original coder when to the trouble to document > the place that this was inherited from for readers of the code. I see. Probably a job for IDEs in general, though. > The point of the exercise is to make the checkstyle > of ant to be a usefull activity Which is a good step. -J. -- jesse.glick@sun.com x22801 netbeans.org ant.apache.org http://google.com/search?q=e%5E%28pi*i%29%2B1 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org