Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 53089 invoked from network); 1 Nov 2006 15:57:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 Nov 2006 15:57:43 -0000 Received: (qmail 84066 invoked by uid 500); 1 Nov 2006 15:57:53 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 84007 invoked by uid 500); 1 Nov 2006 15:57:53 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 83996 invoked by uid 99); 1 Nov 2006 15:57:53 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Nov 2006 07:57:53 -0800 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of ddevienne@gmail.com designates 64.233.184.230 as permitted sender) Received: from [64.233.184.230] (HELO wr-out-0506.google.com) (64.233.184.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Nov 2006 07:57:37 -0800 Received: by wr-out-0506.google.com with SMTP id i11so518895wra for ; Wed, 01 Nov 2006 07:57:17 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=O/ZhAeDFstd7z9kiVplD8q3m9I7tbO8MIuU2dTFvbjtqEB0ML0A6Pr2zuzcw5mOA/D8Y5yrjsoToH0J1OHJ/29D275UkYw6a3JLs9DNQLkD/TMffbTLLlQIEydhAnYaXhfanqGL86WdjAnC8FpFZ91YYOGJg6z6kuPbqNAI7L8A= Received: by 10.78.127.6 with SMTP id z6mr9039451huc; Wed, 01 Nov 2006 07:57:15 -0800 (PST) Received: by 10.78.178.3 with HTTP; Wed, 1 Nov 2006 07:57:15 -0800 (PST) Message-ID: <255d8d690611010757xf274c69x7df78b52137c800b@mail.gmail.com> Date: Wed, 1 Nov 2006 09:57:15 -0600 From: "Dominique Devienne" To: "Ant Developers List" Subject: Re: svn commit: r469781 - in /ant/core/trunk/src/main/org/apache/tools/ant: ProjectComponent.java types/AbstractFileSet.java types/DataType.java types/PatternSet.java In-Reply-To: <20061101154310.275500@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20061101051128.722741A9846@eris.apache.org> <255d8d690611010543k4c22d1c8s3931d90cb99f3749@mail.gmail.com> <20061101154310.275500@gmx.net> X-Virus-Checked: Checked by ClamAV on apache.org > I have decided that PatternSet.clone() should return also a reference rather than the referenced object if the object is a reference. > > When the object is used, the different getters will bring the user back to the referenced object. The only little concern I had with this approach was that if the referenced object was changed between the moment the referencer is cloned, and the moment it effectively accesses the cloned referencer instance (and thus the modified referenced instance), accessing the cloned reference may gives a false sense of "security", the user thinking the clone is private and won't change, despite the fact that it's still "just" a proxy (reference in Ant terms) to another instance, that one not cloned. Confusing statement, I know ;-) --DD --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org