ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Reilly" <peter.kitt.rei...@gmail.com>
Subject Re: Did 1.7RC1 break JUnit 4.x compatibility?
Date Wed, 15 Nov 2006 15:58:39 GMT
On 11/15/06, Stan Guillory <Stan.Guillory@wnco.com> wrote:
>
> Well, you guys are going to kill me. It turned out to be a classpath
> issue on my part.

Excellent..

> In our actual build system, we use a two layer
> approach to ant build files: a master build file in a thirdparty area
> that local build files import and augment if necessary. The master build
> file builds up various classpath references for compile, runtime, test,
> etc.
>
> We use spring, and to get the spring.jar on the compile.classpath, we
> were slurping up every jar in the spring 2.0 distribution, which
> unfortunately included some version of ant.jar.

This could explain why the JUnitTestRunner did not
start - classloader issues.

JUnitTest will still need to be changed to handle
a missing vmwatcher file.

Peter

> Once I winnowed the
> spring related jars down to just the ones we needed explicitly,
> everything was goodness, and my test reports once again had meaning.
>
> Thanks for your time and consideration.
>
> Stan
>
>
> -----Original Message-----
> From: Peter Reilly [mailto:peter.kitt.reilly@gmail.com]
> Sent: Wednesday, November 15, 2006 9:21 AM
> To: Ant Developers List
> Subject: Re: Did 1.7RC1 break JUnit 4.x compatibility?
>  better handling/diagnostics for in any situation.
>
> Looking at the code, the following could have happened:
> In JUnitTest, the vmwatcher file name is created (no file is written).
> The JUnitTestRunner class is executes in a new vm, it fails before it
> processess all the arguments, i.e. before processing the CRASHFILE
> arguement, which creates the vmwatcher file and writes info to it.
> The "finally" part of JUnitTest#nexecuteAsForked is run, it does not
> check if the vmwatcher file is present before opening it.
>
> So there is two problems here:
>  1) JUnitTestRunner cannot be run (cannot load class ?), or it only runs
> for a small time
>      (commandline args are messed up ?)
>  2) error handling in JUnitTest#executeAsForked is wonky.
>
> 2) can be solved easily
> For 1) we need more information.
> - try to reduce to the smallest set of files that show the problem.
>
> Peter
>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> > commands, e-mail: dev-help@ant.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> commands, e-mail: dev-help@ant.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message