ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martijn Kruithof <...@apache.org>
Subject Re: seemingly infinite loop in Project class
Date Fri, 24 Nov 2006 18:36:42 GMT
Peter Reilly schreef:
> On 11/23/06, Dave Brosius <dbrosius@apache.org> wrote:
>>     protected void fireMessageLogged(Project project, String message,
>>                                      int priority) {
>>         fireMessageLogged(project, message, priority);
>>     }
> That does incorrect.....
> It possible should be fireMessageLogged(project, message, null, 
> priority).
> The question is why is there so many variants of fireMessageLogged(), 
> +Event
> - they are protected methods - so they can only be used by derived 
> classses
> of Project and by classes within o.a.t.a ?
>
> Peter
Yep it is incorrect.

I have added, and not removed the methods because of backward 
compatibility. In my view protected methods are just as public as public 
methods (we may have users we do not know of, and they would be 
rightfully using it). If they would have been package scoped I would not 
have mercy.

Martijn

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message