ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peterrei...@apache.org
Subject svn commit: r476569 - in /ant/core/trunk/src/main/org/apache/tools/zip: JarMarker.java UnrecognizedExtraField.java ZipFile.java ZipOutputStream.java
Date Sat, 18 Nov 2006 17:58:00 GMT
Author: peterreilly
Date: Sat Nov 18 09:57:58 2006
New Revision: 476569

URL: http://svn.apache.org/viewvc?view=rev&rev=476569
Log:
checkstyle

Modified:
    ant/core/trunk/src/main/org/apache/tools/zip/JarMarker.java
    ant/core/trunk/src/main/org/apache/tools/zip/UnrecognizedExtraField.java
    ant/core/trunk/src/main/org/apache/tools/zip/ZipFile.java
    ant/core/trunk/src/main/org/apache/tools/zip/ZipOutputStream.java

Modified: ant/core/trunk/src/main/org/apache/tools/zip/JarMarker.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/zip/JarMarker.java?view=diff&rev=476569&r1=476568&r2=476569
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/zip/JarMarker.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/zip/JarMarker.java Sat Nov 18 09:57:58 2006
@@ -28,17 +28,19 @@
  */
 public final class JarMarker implements ZipExtraField {
 
-    private static ZipShort ID = new ZipShort(0xCAFE);
-    private static ZipShort NULL = new ZipShort(0);
-    private static byte[] NO_BYTES = new byte[0];
-    private static JarMarker DEFAULT = new JarMarker();
+    private static final ZipShort ID = new ZipShort(0xCAFE);
+    private static final ZipShort NULL = new ZipShort(0);
+    private static final byte[] NO_BYTES = new byte[0];
+    private static final JarMarker DEFAULT = new JarMarker();
 
+    /** No-arg constructor */
     public JarMarker() {
         // empty
     }
 
     /**
      * Since JarMarker is stateless we can always use the same instance.
+     * @return the DEFAULT jarmaker.
      */
     public static JarMarker getInstance() {
         return DEFAULT;

Modified: ant/core/trunk/src/main/org/apache/tools/zip/UnrecognizedExtraField.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/zip/UnrecognizedExtraField.java?view=diff&rev=476569&r1=476568&r2=476569
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/zip/UnrecognizedExtraField.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/zip/UnrecognizedExtraField.java Sat Nov 18 09:57:58
2006
@@ -124,6 +124,9 @@
     }
 
     /**
+     * @param data the array of bytes.
+     * @param offset the source location in the data array.
+     * @param length the number of bytes to use in the data array.
      * @see ZipExtraField#parseFromLocalFileData(byte[], int, int)
      */
     public void parseFromLocalFileData(byte[] data, int offset, int length) {

Modified: ant/core/trunk/src/main/org/apache/tools/zip/ZipFile.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/zip/ZipFile.java?view=diff&rev=476569&r1=476568&r2=476569
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/zip/ZipFile.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/zip/ZipFile.java Sat Nov 18 09:57:58 2006
@@ -72,8 +72,8 @@
     private Hashtable nameMap = new Hashtable(509);
 
     private static final class OffsetEntry {
-        long headerOffset = -1;
-        long dataOffset = -1;
+        private long headerOffset = -1;
+        private long dataOffset = -1;
     }
 
     /**

Modified: ant/core/trunk/src/main/org/apache/tools/zip/ZipOutputStream.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/zip/ZipOutputStream.java?view=diff&rev=476569&r1=476568&r2=476569
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/zip/ZipOutputStream.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/zip/ZipOutputStream.java Sat Nov 18 09:57:58
2006
@@ -193,6 +193,8 @@
      */
     private String encoding = null;
 
+    // CheckStyle:VisibilityModifier OFF - bc
+
     /**
      * This Deflater object is used for output.
      *
@@ -217,6 +219,8 @@
      */
     protected byte[] buf = new byte[512];
 
+    // CheckStyle:VisibilityModifier ON
+
     /**
      * Optional random access output.
      *
@@ -881,7 +885,8 @@
     /**
      * Assumes a negative integer really is a positive integer that
      * has wrapped around and re-creates the original value.
-     *
+     * @param i the value to treat as unsigned int.
+     * @return the unsigned int as a long.
      * @since 1.34
      */
     protected static long adjustToLong(int i) {



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message