ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peterrei...@apache.org
Subject svn commit: r475075 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/image/Image.java
Date Wed, 15 Nov 2006 00:09:01 GMT
Author: peterreilly
Date: Tue Nov 14 16:09:00 2006
New Revision: 475075

URL: http://svn.apache.org/viewvc?view=rev&rev=475075
Log:
checkstyle

Modified:
    ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/image/Image.java

Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/image/Image.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/image/Image.java?view=diff&rev=475075&r1=475074&r2=475075
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/image/Image.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/image/Image.java Tue Nov
14 16:09:00 2006
@@ -51,18 +51,25 @@
  * @see org.apache.tools.ant.types.DataType
  */
 public class Image extends MatchingTask {
+    // CheckStyle:VisibilityModifier OFF - bc
     protected Vector instructions = new Vector();
     protected boolean overwrite = false;
     protected Vector filesets = new Vector();
     protected File srcDir = null;
     protected File destDir = null;
 
+    // CheckStyle:MemberNameCheck OFF - bc
+
     //cannot remove underscores due to protected visibility >:(
     protected String str_encoding = "JPEG";
     protected boolean garbage_collect = false;
 
     private boolean failonerror = true;
 
+    // CheckStyle:MemberNameCheck ON
+
+    // CheckStyle:VisibilityModifier ON
+
     /**
      * Add a set of files to be deleted.
      * @param set the FileSet to add.
@@ -198,12 +205,12 @@
             if (destDir == null) {
                 destDir = srcDir;
             }
-            File new_file = new File(destDir, file.getName());
+            File newFile = new File(destDir, file.getName());
 
-            if ((overwrite && new_file.exists()) && (!new_file.equals(file)))
{
-                new_file.delete();
+            if ((overwrite && newFile.exists()) && (!newFile.equals(file)))
{
+                newFile.delete();
             }
-            FileOutputStream stream = new FileOutputStream(new_file);
+            FileOutputStream stream = new FileOutputStream(newFile);
 
             JAI.create("encode", image, stream, str_encoding.toUpperCase(),
                        null);
@@ -261,8 +268,8 @@
                 ArrayList filesToRemove = new ArrayList();
                 for (Iterator i = filesList.iterator(); i.hasNext();) {
                     File f = (File) i.next();
-                    File new_file = new File(destDir, f.getName());
-                    if (new_file.exists()) {
+                    File newFile = new File(destDir, f.getName());
+                    if (newFile.exists()) {
                         filesToRemove.add(f);
                     }
                 }



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message