ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peterrei...@apache.org
Subject svn commit: r473114 - /ant/core/trunk/src/main/org/apache/tools/ant/types/FilterSet.java
Date Thu, 09 Nov 2006 22:42:24 GMT
Author: peterreilly
Date: Thu Nov  9 14:42:23 2006
New Revision: 473114

URL: http://svn.apache.org/viewvc?view=rev&rev=473114
Log:
checkstyle

Modified:
    ant/core/trunk/src/main/org/apache/tools/ant/types/FilterSet.java

Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/FilterSet.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/FilterSet.java?view=diff&rev=473114&r1=473113&r2=473114
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/types/FilterSet.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/types/FilterSet.java Thu Nov  9 14:42:23
2006
@@ -41,11 +41,13 @@
      *
      */
     public static class Filter {
+        // CheckStyle:VisibilityModifier OFF - bc
         /** Token which will be replaced in the filter operation. */
         String token;
 
         /** The value which will replace the token in the filtering operation. */
         String value;
+        // CheckStyle:VisibilityModifier ON
 
         /**
          * Constructor for the Filter object.
@@ -132,8 +134,11 @@
         private static final String[] VALUES
             = new String[] {"fail", "warn", "ignore"};
 
+        /** Fail value */
         public static final OnMissing FAIL = new OnMissing("fail");
+        /** Warn value */
         public static final OnMissing WARN = new OnMissing("warn");
+        /** Ignore value */
         public static final OnMissing IGNORE = new OnMissing("ignore");
 
         private static final int FAIL_INDEX = 0;
@@ -155,6 +160,7 @@
         }
 
         //inherit doc
+        /** {@inheritDoc}. */
         public String[] getValues() {
             return VALUES;
         }
@@ -254,6 +260,7 @@
      *
      * @param filtersFile sets the filter file from which to read filters
      *        for this filter set.
+     * @throws BuildException if there is an error.
      */
     public void setFiltersfile(File filtersFile) throws BuildException {
         if (isReference()) {
@@ -599,6 +606,9 @@
             throw new BuildException(message);
         case OnMissing.WARN_INDEX:
             log(message, Project.MSG_WARN);
+            return;
+        default:
+            throw new BuildException("Invalid value for onMissingFiltersFile");
         }
     }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message