Return-Path: 
 <dev-return-76252-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 27623 invoked from network); 29 Oct 2006 20:34:13 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 29 Oct 2006 20:34:13 -0000
Received: (qmail 64495 invoked by uid 500); 29 Oct 2006 20:34:12 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 64460 invoked by uid 500); 29 Oct 2006 20:34:12 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 64445 invoked by uid 99); 29 Oct 2006 20:34:12 -0000
Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 29 Oct 2006 12:34:12 -0800
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: neutral (herse.apache.org: local policy)
Received: from [88.84.142.181] (HELO v30161.1blu.de) (88.84.142.181)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 29 Oct 2006 12:33:59 -0800
Received: (qmail 21762 invoked by uid 2525); 29 Oct 2006 21:29:42 +0100
To: dev@ant.apache.org
Subject: Re: <war> and web.xml
X-Draft-From: ("nnfolder:mail.jakarta-ant" 77602)
References: <4543BE6E.60107@apache.org>
From: Stefan Bodewig <bodewig@apache.org>
Date: Sun, 29 Oct 2006 21:29:42 +0100
In-Reply-To: <4543BE6E.60107@apache.org> (Steve Loughran's message of "Sat,
 28 Oct 2006 21:32:46 +0100")
Message-ID: <y1u64e2vpah.fsf@v30161.1blu.de>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.19 (linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Checked: Checked by ClamAV on apache.org

On Sat, 28 Oct 2006, Steve Loughran <stevel@apache.org> wrote:

> 4. You can then pull in a web.xml file via the webxml attribute, or
> via a nested fileset. In either case we say "Although needxmlfile is
> false, a web.xml file was included " ... and point to the file that
> was added.

Sounds good.

> 5. once you set needxmlfile=false, and omit the web.xml attribute,
> you can pull in a WEB-INF/web.xml from a fileset. What if there is
> >1 match in the fileset? The first one added wins; there is no extra
> warning message.

I'd prefer a warning about duplicates.

> 6. When updating an existing war file, if update=false and
> needxmlfile=false, then things get complex. The problem here is that
> there isnt a webxml file, so stuff from filesets get pulled in. but
> dependency logic in the fileset checking engages first.

Where do you see a problem?  I'd still see whether we add a web.xml
and treat the case similar to (4).

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org