Return-Path: 
 <dev-return-75697-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 31678 invoked from network); 10 Oct 2006 21:18:57 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 10 Oct 2006 21:18:57 -0000
Received: (qmail 3158 invoked by uid 500); 10 Oct 2006 21:18:56 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 3116 invoked by uid 500); 10 Oct 2006 21:18:55 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 3105 invoked by uid 99); 10 Oct 2006 21:18:55 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Oct 2006 14:18:55 -0700
X-ASF-Spam-Status: No, hits=1.4 required=10.0
	tests=SPF_NEUTRAL
X-Spam-Check-By: apache.org
Received-SPF: neutral (asf.osuosl.org: 62.24.64.34 is neither permitted nor
 denied by domain of caster@gentoo.org)
Received: from [62.24.64.34] (HELO slimak.dkm.cz) (62.24.64.34)
    by apache.org (qpsmtpd/0.29) with SMTP; Tue, 10 Oct 2006 14:18:54 -0700
Received: (qmail 65564 invoked by uid 0); 10 Oct 2006 21:18:31 -0000
Received: from r141.net.upc.cz (HELO ?192.168.1.1?) (62.24.83.141)
  by slimak.dkm.cz with SMTP; 10 Oct 2006 21:18:31 -0000
Message-ID: <452C0E26.1090207@gentoo.org>
Date: Tue, 10 Oct 2006 23:18:30 +0200
From: Vlastimil Babka <caster@gentoo.org>
User-Agent: Thunderbird 1.5.0.7 (X11/20060917)
MIME-Version: 1.0
To: dev@ant.apache.org
Subject: <include> behaviour in <javac> changed between ant 1.6.5 and
 1.7.0_beta2?
X-Enigmail-Version: 0.94.1.0
OpenPGP: id=4E61DE84;
	url=subkeys.pgp.net
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I've run into the following problem while compiling commons-logging-1.1
with 1.7.0_beta2:

- ----START----

log4j12-warning:

log4j13-warning:

logkit-warning:

jdk1.4-warning:

avalon-framework-warning:
     [echo]
     [echo]     *** WARNING ***
     [echo]     Avalon-Framework not found: Cannot Build AvalonLogger
     [echo]

compile-non-log4j:
    [javac] Compiling 12 source files to
/var/tmp/portage/commons-logging-1.1-r1/work/commons-logging-1.1-src/target/classes
    [javac] ----------
...

compile-1.4:

warning:

show-lib-presence:
     [echo] jdk.1.4.present=true
     [echo] log4j12.present=true
     [echo] logkit.present=true
     [echo] avalon-framework.present=${avalon-framework.present}

compile-log4j12:
    [javac] Compiling 1 source file to
/var/tmp/portage/commons-logging-1.1-r1/work/commons-logging-1.1-src/target/classes
    [javac] ----------
...

compile-log4j13:
    [javac] Compiling 1 source file to
/var/tmp/portage/commons-logging-1.1-r1/work/commons-logging-1.1-src/target/classes
    [javac] ----------
    [javac] 1. ERROR in
/var/tmp/portage/commons-logging-1.1-r1/work/commons-logging-1.1-src/src/java/org/apache/commons/logging/impl/AvalonLogger.java

- ----END----

This is the relevant part of build.xml:

- ----START----

  <target depends="prepare,discovery" name="compile-log4j13">
    <!-- compile the log4j1.3 support classes -->
    <javac debug="${compile.debug}" deprecation="${compile.deprecation}"
destdir="${build.home}/classes" optimize="${compile
.optimize}" source="1.3" srcdir="${source.home}" target="1.3">

      <classpath refid="compile.classpath"/>
      <classpath>
        <pathelement location="${log4j13.jar}"/>
      </classpath>

    <!--
      - Note: log4j13 support not available in 1.1 release. However if
we do add it
      - in a future release, this entry will pick it up. In the
meantime, this
      - simply compiles no classes.
      -->
      <include if="log4j13.present"
name="org/apache/commons/logging/impl/Log4J13Logger.java"/>
    </javac>
  </target>

- ----END----

And this happens with ant 1.6.5:

- ----START----
compile-log4j12:
    [javac] Compiling 1 source file to
/var/tmp/portage/commons-logging-1.1-r1/work/commons-logging-1.1-src/target/classes
    [javac] ----------
...

compile-log4j13:

build-jar:
...
BUILD SUCCESSFUL

- ----END----

My conclusion is that in 1.6.5, when the only <include> fails its "if"
clause, javac's implicit fileset is presumed empty and "opt-in" and
nothing gets compiled. But in 1.7.0_beta2, failed <include> presumes
implicit fileset is whole srcdir (the fact it only compiles
AvalonLogger.java is probably because everything else was compiled in
previous targets).

Not sure which behaviour is more correct, i.e. if the difference is a
bug or feature. If it's a feature, I think it should be documented in
changelog, preferably the "Changes that could break older environments"
part (unless I'm blind and missing it somewhere :)

Regards

- --
Vlastimil Babka (Caster)
Gentoo/Java
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFLA4ltbrAj05h3oQRAhwXAKCHpxLbz369PLIj/PI7vfc7Zji+0ACdHWr/
Jq0+CoQuYbADmSjE/6WJqnI=
=kTyT
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org