ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antoine Levy-Lambert" <anto...@gmx.de>
Subject Re: svn commit: r452635 - /ant/core/trunk/src/main/org/apache/tools/ant/RuntimeConfigurable.java
Date Wed, 04 Oct 2006 22:48:16 GMT
Hi,

Actually, I just read this bug report [1] that Peter processed and which describes a similar
scenario with a zipfileset which gets specialized in a refid.

 <zipfileset id="test.fileset"
                dir="${basedir}"
                includes="test1.jar,test2.jar,test3.jar"/>
                
    <target name="fails">
        <jar destfile="test.war">
            <zipfileset refid="test.fileset"
                        prefix="WEB-INF/lib/"/>
        </jar>
    </target>

Regards,

Antoine
[1] http://issues.apache.org/bugzilla/show_bug.cgi?id=30498

-------- Original-Nachricht --------
Datum: Thu, 05 Oct 2006 00:43:44 +0200
Von: "Antoine Levy-Lambert" <antoine@gmx.de>
An: "Ant Developers List" <dev@ant.apache.org>
Betreff: Re: svn commit: r452635 - /ant/core/trunk/src/main/org/apache/tools/ant/RuntimeConfigurable.java

> Hi,
> 
> I think that some guys do the following :
> 
> <fileset dir="foo" id="foofileset"/>
> <zipfileset refid="foofileset" prefix="libraries"/>
> 
> We came across this when I did the work to make zipfileset become a top
> level type in 1.6. At some stage the construct above did not work any more
> and some projects in gump did not build. I do not remember the exact details.
> 
> Antoine
> -------- Original-Nachricht --------
> Datum: Wed, 4 Oct 2006 17:00:55 -0500
> Von: "Dominique Devienne" <ddevienne@gmail.com>
> An: "Ant Developers List" <dev@ant.apache.org>
> Betreff: Re: svn commit: r452635 -
> /ant/core/trunk/src/main/org/apache/tools/ant/RuntimeConfigurable.java
> 
> > > > Why stop there, and not enforce refid as the sole authorized
> attribute
> > >
> > > Good point, However, I am sure that some type out there depends
> > > on the current behaviour.   Peter
> > 
> > Since they break the principle of least surprise, I wouldn't mind
> > breaking them ;-)  But I fear I don't represent the majority in the
> > case. Yet the core substituting the reference with the proper
> > referenced type would be so much better. --DD
> > 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message