ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 40504] - Provide sort task like UNIX sort function
Date Sun, 01 Oct 2006 21:47:19 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40504>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40504





------- Additional Comments From achepati67@yahoo.es  2006-10-01 14:47 -------
Dear Antoine and others,

Following your recomendation I have added a patch with an implementation of 
SortFilter, it implements ChainableReader, because I think it have to, but I 
am not sure.

Because the UNIX sort function, has a lot of different possibilities, such 
amount of possible options from Java point of view can be only considered 
alowing the user just to define a Comparator implementation. That is my 
approach in general for this features, except for common criterias such us: 
Reverse order, considered via reverse parameter.

This approach allow in a future multiple extension points adding new 
parameters.

Note: I didn't implement the test of invoking recursively two or more sorting 
criteria at the same time (That is why I guess it has to implement 
ChainableReader). I guess it is easy to implement this test, invoking ant like 
this:

<target name="testSortFilterTwo" depends="init">
    <copy file="input/sort.sortDefault.test"
      tofile="result/sort.sortDefault.test">
      <filterchain>
        <filterreader classname="org.apache.tools.ant.filters.SortFilter">
          <param name="reverse" value="true"/>
        </filterreader>
        <filterreader classname="org.apache.tools.ant.filters.SortFilter">
        </filterreader>
      </filterchain>
    </copy>
</target>

the result has to be the same as testSortFilterNoArgs test case.

On the patch I have respected the same directory structure as in the SVN:

http://svn.apache.org/repos/asf/ant/core/trunk/src/

Regards,

David

P.S.: I am going to implement now a similar filter for diff command (I need 
both of them on my project), my idea is:

<filterchain>
    <diff reference="referenceFile.txt"/>
</filterchain>

It can be implemented in a similar way as <concat> Ant Task, nevertheless via 
filter is also a good solution for that. I am going to add a new patch for 
that (when I done it)


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message