ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <Jan.Mate...@rzf.fin-nrw.de>
Subject AW: svn commit: r450609 - /ant/core/trunk/src/main/org/apache/tools/ant/util/ConcatResourceInputStream.java
Date Thu, 28 Sep 2006 13:23:04 GMT
>Log:
>add @since tag, remove unthrowable constructor exception, and 
>shrink some stuff
>
>Modified:
>    
>ant/core/trunk/src/main/org/apache/tools/ant/util/ConcatResourceInputSt
ream.java
>
>@@ -104,16 +104,12 @@
>         if (managingPc != null) {
>             managingPc.log(message, loglevel);
>         } else {
>-            if (loglevel > Project.MSG_WARN) {
>-                System.out.println(message);
>-            } else {
>-                System.err.println(message);
>-            }
>+            (loglevel > Project.MSG_WARN ? System.out : 
>+ System.err).println(message);
>         }
>     }

>     private int readCurrent() throws IOException {
>-        return (eof || currentStream == null) ? EOF :
currentStream.read();
>+        return eof || currentStream == null ? EOF : 
>+ currentStream.read();
>     }




>Modified:
>    ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Concat.java

>@@ -252,7 +252,7 @@
>      * @since Ant 1.7
>      */
>     public void add(ResourceCollection c) {
>-        rc = (rc == null) ? new Resources() : rc;
>+        rc = rc == null ? new Resources() : rc;
>         rc.add(c);
>     }



What is the advantage apart from decreasing readability?

Jan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message