ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martijn Kruithof ...@kruithof.xs4all.nl>
Subject Re: VOTE: deferring resolving of references
Date Fri, 29 Sep 2006 16:32:01 GMT
Peter Reilly wrote:

> Impact: It is a one-line change.
> Influence release of 1.7: I do not think so.
> (I think that we need to release an ant 1.7beta3 soon, freeze commits
> after that (or branch) and try to get as many users to try it out.)
>
> There are BC issues: some scripts may depend on references
> defined in tasks that are not run, for example
>
> <target name="not-run">
>   <delete>
>        <fileset id=" delete.id" dir="build"/>
>    </delete>
> </target>
>
> <target name="clean">
>   <delete>
>       <fileset refid="delete.id "/>
>   </delete>
> </target>
>
> Such scripts I would consider to be dodgy.
>
> Peter
>
In that case +1

>
> On 9/29/06, Martijn Kruithof <jm@kruithof.xs4all.nl> wrote:
>
>>
>> Peter Reilly wrote:
>>
>> > Hi, I started a thead last week that did not end in a conclusion.
>> > should we defer resolving references until runtime:
>> > original message
>> > "
>> > Currently in ant, there is two steps in processing
>> > a project build file, a parsing step and an execution
>> > step. In the parsing step a DOM like structure of
>> > Targets and UnknownElements are build up.
>> > These targets and unknown elements are then processed
>> > in the execution step. This model works quite ok.
>> > One part that does not work like this is the processing
>> > of the "id" attribute, these get processed at parsing
>> > stage.
>> >
>> > This has given rise to a lot of bugs and strange behaviour.
>> > http://issues.apache.org/bugzilla/show_bug.cgi?id=34458
>> > http://issues.apache.org/bugzilla/show_bug.cgi?id=36955
>> > http://issues.apache.org/bugzilla/show_bug.cgi?id=37688
>> > http://issues.apache.org/bugzilla/show_bug.cgi?id=21724
>> >
>> > This type of bug will happen more as people write
>> > larger build files (or equivalate using lots of <import> and 
>> <macrodef>)
>> > and use shared build files.
>> >
>> > I propose that we defer handing id's until the processing
>> > stage.
>> > "
>> > thread: http://marc.theaimsgroup.com/?t=115893367000004&r=1&w=2
>> >
>> > Vote to include deferring for ant 1.7:
>> >   Yes [  ]
>> >   No [ ]
>> >
>> > I will start with
>> >  Yes [x]
>> >
>> > Peter
>> >
>> How big is the impact?
>> How will this influence the release of 1.7?
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>> For additional commands, e-mail: dev-help@ant.apache.org
>>
>>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message