ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antoine Levy-Lambert" <anto...@gmx.de>
Subject Re: svn commit: r451000 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/ main/org/apache/tools/ant/taskdefs/condition/ tests/junit/org/apache/tools/ant/
Date Fri, 29 Sep 2006 11:02:11 GMT
Hi,

one of the ideas which is nearly always guiding me when I program is that if you depict pears
as oranges in your code it is generating a bad smell and might fail on you later.

maybe we need a generic way to adapt a condition to become a task, for instance 

<conditionadapter>
   <if>
      <and>
         <isset property="blue sky"/>
         <waitfor .../>
      </and> 
   </if>
   <then>
   </then>
   <else>
   </else> 
</conditionadapter>

the then and else tags would be the equivalent of <sequential/> in macrodef.

Uhhmm. Maybe the above already exists in ant-contrib somehow ?

Antoine
-------- Original-Nachricht --------
Datum: Fri, 29 Sep 2006 11:50:42 +0100
Von: Steve Loughran <stevel@apache.org>
An: Ant Developers List <dev@ant.apache.org>
Betreff: Re: svn commit: r451000 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/
main/org/apache/tools/ant/taskdefs/condition/ tests/junit/org/apache/tools/ant/

> Antoine Levy-Lambert wrote:
> > Hello Peter,
> > 
> > -------- Original-Nachricht --------
> > Datum: Fri, 29 Sep 2006 09:44:44 +0100
> > Von: "Peter Reilly" <peter.kitt.reilly@gmail.com>
> > An: "Ant Developers List" <dev@ant.apache.org>
> > Betreff: Re: svn commit: r451000 - in /ant/core/trunk/src:
> main/org/apache/tools/ant/taskdefs/ main/org/apache/tools/ant/taskdefs/condition/
> tests/junit/org/apache/tools/ant/
> >> there are some issues remaining. I cannot find the e-mail,
> >> but someone was
> >> talking about needing to do some work-arounds for <condition> in
> >> processing tasks in a nested sequential, 
> > it would be interesting to find out which problem this was exactly
> 
> It was me. I have a <functionaltest> task that does functional testing; 
> and a FaultingWaitFor task that reimplemented waitfor as a task 
> (throwing a fault of the condition wasnt met by the timeout)
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message