ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antoine Levy-Lambert" <anto...@gmx.de>
Subject Re: svn commit: r450863 - in /ant/core/trunk: CONTRIBUTORS WHATSNEW contributors.xml src/main/org/apache/tools/ant/types/resources/URLResource.java
Date Fri, 29 Sep 2006 08:33:45 GMT
Hello Peter,

thanks for your suggestion, I have just committed the change.

Regards,

Antoine
-------- Original-Nachricht --------
Datum: Thu, 28 Sep 2006 15:41:39 +0100
Von: "Peter Reilly" <peter.kitt.reilly@gmail.com>
An: "Ant Developers List" <dev@ant.apache.org>
Betreff: Re: svn commit: r450863 - in /ant/core/trunk: CONTRIBUTORS WHATSNEW contributors.xml
src/main/org/apache/tools/ant/types/resources/URLResource.java

> URL:
> >
> http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/resources/URLResource.java?view=diff&rev=450863&r1=450862&r2=450863
> >
> >
> ==============================================================================
> > ---
> >
> ant/core/trunk/src/main/org/apache/tools/ant/types/resources/URLResource.java
> > (original)
> > +++
> >
> ant/core/trunk/src/main/org/apache/tools/ant/types/resources/URLResource.java
> > Thu Sep 28 07:23:26 2006
> > @@ -361,7 +361,6 @@
> >       * @throws Throwable on error.
> >       */
> >      protected void finalize() throws Throwable {
> > -        close();
> >          conn = null;
> >          super.finalize();
> >      }
> 
> 
> My advice would be to remove the finalize method completely.
> Having a finalize method is not good practice - it interacts badly
> with GC.
> the current version of this method in effect does nothing except trying to
> "help" gc.
> see:
> 
> http://devresource.hp.com/drc/resources/jmemmodel/index.jsp
> 
> 

> >

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message