ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antoine Levy-Lambert" <anto...@gmx.de>
Subject Re: svn commit: r451000 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/ main/org/apache/tools/ant/taskdefs/condition/ tests/junit/org/apache/tools/ant/
Date Fri, 29 Sep 2006 07:34:41 GMT
Hello Peter,

I would like simply to understand why you did this change. What does this bring us ?

A class that does not have an execute method is semantically not a task. So I would also say
that such a class should not extend Task.

Can we find a way to get whatever you want to achieve by this change in a way which makes
sense semantically ? I remember we were discussing before about maybe declaring conditions
with typedefs. Would this be something which would address your concerns ?


Regards,

Antoine
-------- Original-Nachricht --------
Datum: Fri, 29 Sep 2006 05:31:10 +0200
Von: Stefan Bodewig <bodewig@apache.org>
An: dev@ant.apache.org
Betreff: Re: svn commit: r451000 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/
main/org/apache/tools/ant/taskdefs/condition/ tests/junit/org/apache/tools/ant/

> On Thu, 28 Sep 2006, <peterreilly@apache.org> wrote:
> 
> > Make conditionbase a Task.
> > ?was there any reason that this was not done for ant 1.6?
> 
> When I brought the whole condition eco-system into 1.4, I decided
> against extending Task because some of the conditions themselves
> extend ConditionBase as well.  When you make ConditionBase extend Task
> this suddenly turns <and>, <or> and <not> into tasks.
> 
> I also don't think it's a good idea to extend task but not provide an
> implementation of execute().
> 
> Stefan
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message