ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@yahoo.com>
Subject Re: svn commit: r439014 - in /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/condition: ConditionBase.java antlib.xml
Date Fri, 01 Sep 2006 15:57:37 GMT
--- Steve Loughran <stevel@apache.org> wrote:

> Matt Benson wrote:
> > --- Steve Loughran <stevel@apache.org> wrote:
> > 
> >> mbenson@apache.org wrote:
> >>> Author: mbenson
> >>> Date: Thu Aug 31 12:04:12 2006
> >>> New Revision: 439014
> >>>
> >>> URL:
> >> http://svn.apache.org/viewvc?rev=439014&view=rev
> >>> Log:
> >>> Auto-discover built-in conditions added >= 1.7
> >> from the accompanying antlib so we can stop
> adding
> >> junk setters to ConditionBase.
[SNIP]
> > 
> > please add new conditions to
> > oata.types.conditions/antlib.xml instead of
> > here, to avoid namespace clash with things like
> > selectors.
> > 
> 
> 
> > I suspected, but did not bother to check, who that
> > committer was yesterday.  Today I checked and
> found my
> > suspicions were correct.  It was you, Steve!  :) 
> So
> > do you recall your train of thought when you added
> > this admonition to the properties file?  Do you
> > retract that opinion; shall we doubly define
> > non-colliding conditions in the antlib as well as
> > oata.types/defaults.properties?
> > 
> 
> I think Stefan told me off :)
> 
> Here's the problem
> 
> -ant's core conditions are not defined as types
> -third party classes cannot go add(Condition) and
> get all conditions
> -I stuck the antlib in to make it possible, but dont
> think we have any 
> tests for it being included in the JAR
> -If you do make them a type, there is the problem
> that a <contains> 
> selector already exists, and now we have a
> <contains> test.
> 
> To make things more entertaining, if you do extend
> ConditionBase, you 
> don't have a task.

But with taskadapters, can't any class with an
execute() method function as a task?  As does
<condition>?

> This really annoyed julio, when
> he was adding the 
> smartfrog component for ant (the one that lets you
> use ant stuff in a 
> smartfrog descriptor, as opposed to the ant tasks
> for smartfrog).
> 
> I had fun in FaultingWaitFor, where I had to
> reimplement waitfor as a 
> task. I cannot get at any of the ant1.7 stuff unless
> it is defined as a 
> condition, because my code needs to build on ant1.6:
> 

Are you saying that the smartfrog stuff uses Ant
tasks, but needs true tasks?  Hmm.

>
http://smartfrog.cvs.sourceforge.net/smartfrog/core/extras/ant/src/org/smartfrog/tools/ant/FaultingWaitForTask.java?view=markup
> 
> To make things more complex, this task gets nested
> in a <functionaltest> 
> task that has a setup, probe, test and application
> in parallel and a 
> finally sequence that runs after the tests. It has 
> an order like
> 
>             setup
>          /               \
>    application   probe (until probe passes or
> timeout)
>           |           test
>           |          finally
>           \           /
>         finished
> 
> We use it for functional testing, obviously.
> 
>
http://smartfrog.cvs.sourceforge.net/smartfrog/core/extras/ant/src/org/smartfrog/tools/ant/FunctionalTestTask.java?view=markup
> 
> DynamicElement has been round since 1.5; the NS is
> more recent, and I 
> dont go near it myself.
> 

So what does all this mean for the issue at hand?  :)

-Matt

> -steve
> 
> 
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org
> For additional commands, e-mail:
> dev-help@ant.apache.org
> 
> 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message